[PATCH] D67961: [libTooling] Introduce the MatchConsumer abstraction

2019-09-25 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL372870: [libTooling] Introduce the MatchConsumer abstraction (authored by ymandel, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D67961: [libTooling] Introduce the MatchConsumer abstraction

2019-09-25 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 221733. ymandel marked 3 inline comments as done. ymandel added a comment. addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67961/new/ https://reviews.llvm.org/D67961 Files: clang/include/cl

[PATCH] D67961: [libTooling] Introduce the MatchConsumer abstraction

2019-09-25 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/MatchConsumer.h:27 + +/// A central abstraction of the Transformer framework is computation over the +/// results of a match (represented by \c MatchFinder

[PATCH] D67961: [libTooling] Introduce the MatchConsumer abstraction

2019-09-25 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/Refactoring/MatchConsumer.h:9 +/// +/// /file This file defines the *MatchConsumer* abstraction: a computation over +/// mat

[PATCH] D67961: [libTooling] Introduce the MatchConsumer abstraction

2019-09-24 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 221531. ymandel added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67961/new/ https://reviews.llvm.org/D67961 Files: clang/include/clang/Tooling/Refactoring/MatchConsumer.h clang/i

[PATCH] D67961: [libTooling] Introduce the MatchConsumer abstraction

2019-09-24 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a project: clang. This revision introduces a separate (small) library for the `MatchConsumer` abstraction: computations over AST match results. This abstraction is central to the Transformer framework, and there dese