[PATCH] D68108: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they are synthesized.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2073dd2da702: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they… (authored by aprantl). Changed prior to commit: https://reviews.llvm.org/D68108?vs=227801=228467#toc

[PATCH] D68108: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they are synthesized.

aprantl added a comment. Thanks for patiently working through this with me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68108/new/ https://reviews.llvm.org/D68108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D68108: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they are synthesized.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, thanks for patiently working through all this review. I'm happy with this now. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5063

[PATCH] D68108: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they are synthesized.

aprantl updated this revision to Diff 227801. aprantl added a comment. Herald added a reviewer: martong. Herald added a reviewer: shafik. Accidentally sent my diff-upon-previous-diff instead of diff against master. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68108/new/

[PATCH] D68108: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they are synthesized.

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5063 const_cast(D), PID); } } rjmccall wrote: > aprantl wrote: > > rjmccall wrote: > > > Is this

[PATCH] D68108: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they are synthesized.

aprantl updated this revision to Diff 227799. aprantl added a comment. Rebased patch and made it slightly more explicit whether an ObjCMethodDecl is a synthesized accessor stub by reserving a bit for it in ObjCMethodDecl. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68108/new/

[PATCH] D68108: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they are synthesized.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5063 const_cast(D), PID); } } aprantl wrote: > rjmccall wrote: > > Is this special treatment still necessary? Won't we encounter the getter

[PATCH] D68108: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they are synthesized.

NoQ edited reviewers, added: NoQ; removed: dergachev.a. NoQ added inline comments. Comment at: clang/test/Analysis/Inputs/expected-plists/nullability-notes.m.plist:191 -10 14 It looks like the body farm for the property accessor has stopped

[PATCH] D68108: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they are synthesized.

aprantl updated this revision to Diff 225729. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68108/new/ https://reviews.llvm.org/D68108 Files: clang/include/clang/AST/DeclObjC.h clang/lib/AST/DeclObjC.cpp clang/lib/Analysis/BodyFarm.cpp clang/lib/CodeGen/CGObjC.cpp

[PATCH] D68108: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they are synthesized.

aprantl updated this revision to Diff 225727. aprantl added a comment. Addressed most of the feedback, explained the rest. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68108/new/ https://reviews.llvm.org/D68108 Files: clang/include/clang/AST/DeclObjC.h clang/lib/AST/DeclObjC.cpp

[PATCH] D68108: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they are synthesized.

aprantl marked 8 inline comments as done. aprantl added inline comments. Comment at: clang/lib/Analysis/BodyFarm.cpp:843 +return Val.getValue(); + Val = nullptr; + rjmccall wrote: > Why did this logic need to change? I don't have a satisfying answer for

[PATCH] D68108: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they are synthesized.

rjmccall added a comment. Also, I think it would be good if there was a more explicit method for asking whether a method is a synthesized definition. Basically, there's a tri-state: there are pure declarations, user-provided definitions, and synthetic definitions. IRGen should emit a

[PATCH] D68108: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they are synthesized.

rjmccall added inline comments. Comment at: clang/include/clang/AST/DeclObjC.h:2787 + /// interface as a decl context. + ObjCMethodDecl *SetterMethodDecl = nullptr; + Are these comments right? The DC is the implementation's interface? Regardless, I think

[PATCH] D68108: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they are synthesized.

theraven added a comment. The changes for the GNU runtimes look correct to me. We're missing a bunch of tests there, unfortunately. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68108/new/ https://reviews.llvm.org/D68108 ___ cfe-commits

[PATCH] D68108: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they are synthesized.

aprantl updated this revision to Diff 222056. aprantl added a comment. Remove `#if 0` from test I used during debugging. (It still passes!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68108/new/ https://reviews.llvm.org/D68108 Files: clang/include/clang/AST/DeclObjC.h

[PATCH] D68108: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they are synthesized.

aprantl created this revision. aprantl added reviewers: rjmccall, dergachev.a, dcoughlin, theraven, ahatanak, erik.pilkington, davide. Herald added subscribers: arphaman, dexonsmith. Herald added a project: clang. aprantl added a child revision: D66121: Debug Info: Nest Objective-C property