[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX abandoned this revision. SouraVX added a comment. Will work on this later! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68117/new/ https://reviews.llvm.org/D68117 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

dblaikie added a subscriber: rsmith. dblaikie added a comment. In D68117#1714091 , @SouraVX wrote: > Hi @probinson @dblaikie @aprantl , I've was investigating and working on > your inputs regarding the problem with DW_at_defaulted once. I think clang >

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX added a comment. Hi @probinson @dblaikie @aprantl , I've was investigating and working on your inputs regarding the problem with DW_at_defaulted once. I think clang has also some issues. Though I'm not able to precisely point out. I ranned into some problems in CFE while marking out_of

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

probinson added a comment. In D68117#1711714 , @dblaikie wrote: > In D68117#1711154 , @probinson wrote: > > > (@dblaikie Aside regarding noreturn, the original DWARF proposal was for a > > debugger wanting to know

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

dblaikie added a comment. In D68117#1711154 , @probinson wrote: > In D68117#1710295 , @dblaikie wrote: > > > I think the existing feature's perhaps a bit misspecified - because where > > you put the DEFAULTED_{in_c

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

probinson added a comment. In D68117#1710295 , @dblaikie wrote: > I think the existing feature's perhaps a bit misspecified - because where you > put the DEFAULTED_{in_class,out_of_class} would communicate that without > needing the two values - if you p

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

dblaikie added a comment. In D68117#1709712 , @probinson wrote: > In D68117#1709557 , @SouraVX wrote: > > > Their's not much information available behind the suggestion or intention > > for adding this feature to S

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

probinson added a comment. In D68117#1709557 , @SouraVX wrote: > Hi David, > I did some digging about DW_AT_defaulted and stuff, not much of a success > but. Here's what I found -- http://dwarfstd.org/Issues.php?type=closed4 -- > here it;s still marke

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX added a comment. In D68117#1708115 , @dblaikie wrote: > In D68117#1708114 , @SouraVX wrote: > > > In D68117#1707680 , @dblaikie > > wrote: > > > > > In D68117#170757

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

dblaikie added a comment. In D68117#1708114 , @SouraVX wrote: > In D68117#1707680 , @dblaikie wrote: > > > In D68117#1707578 , @SouraVX wrote: > > > > > In D68117#1702595

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX added a comment. In D68117#1707680 , @dblaikie wrote: > In D68117#1707578 , @SouraVX wrote: > > > In D68117#1702595 , @probinson > > wrote: > > > > > We really do wa

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

dblaikie added a comment. In D68117#1707578 , @SouraVX wrote: > In D68117#1702595 , @probinson wrote: > > > We really do want to pack the four mutually exclusive cases into two bits. > > I have tried to give more

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX added a comment. In D68117#1702595 , @probinson wrote: > We really do want to pack the four mutually exclusive cases into two bits. I > have tried to give more explicit comments inline to explain how you would do > this. It really should work f

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

probinson added a comment. We really do want to pack the four mutually exclusive cases into two bits. I have tried to give more explicit comments inline to explain how you would do this. It really should work fine, recognizing that the "not defaulted" case is not explicitly represented in the

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX marked 2 inline comments as done. SouraVX added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-defaulted-out-of-class.cpp:25 + + //FIXME -- clang will not mark above member funtions, excluding constructors + // as out of class. If we did not mark destruct

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX marked 3 inline comments as done. SouraVX added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1619 + else { +SPFlags |= llvm::DISubprogram::SPFlagNotDefaulted; + } Previously SPFlagNotDefaulted is setted to SPFlagZero as

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX updated this revision to Diff 223954. SouraVX added a comment. Addressed comments, regarding flags. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68117/new/ https://reviews.llvm.org/D68117 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/dbg-info-all-calls-des

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

probinson added inline comments. Comment at: llvm/include/llvm/IR/DebugInfoFlags.def:91 HANDLE_DISP_FLAG((1u << 8), MainSubprogram) +HANDLE_DISP_FLAG((1u << 9), NotDefaulted) +HANDLE_DISP_FLAG((1u << 10), DefaultedInClass) probinson wrote: > SouraVX wrote: > > a

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

probinson added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1618 + return; +} else if (const auto Def = Method->getDefinition()) { + if (Def->isDefaulted()) { LLVM style is not to use 'else' after 'return'. Comm

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX marked 7 inline comments as done. SouraVX added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1610 + if (const auto *CXXC = dyn_cast(Method)) { +if (CXXC->getCanonicalDecl()->isDeleted()) + SPFlags |= llvm::DISubprogram::SPFlagDeleted; -

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX updated this revision to Diff 223240. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68117/new/ https://reviews.llvm.org/D68117 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/dbg-info-all-calls-described.cpp clang/test/CodeGenCXX/debug-info-defaulted-in-class

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

aprantl added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1610 + if (const auto *CXXC = dyn_cast(Method)) { +if (CXXC->getCanonicalDecl()->isDeleted()) + SPFlags |= llvm::DISubprogram::SPFlagDeleted; can you factor this block out into

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX marked 2 inline comments as done. SouraVX added a comment. Will be adding llvm-dwarfdump tests soon. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1608 + if (CGM.getCodeGenOpts().DwarfVersion >= 5) { +// DWARF-5 support for, defaulted, deleted member functions --

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX updated this revision to Diff 222701. SouraVX added a comment. Added test cases for debug info Clang frontend. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68117/new/ https://reviews.llvm.org/D68117 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/dbg-info-al

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

aprantl added a comment. In D68117#1686929 , @SouraVX wrote: > In D68117#1686235 , @aprantl wrote: > > > This needs a lot more test coverage: The frontend cases aren't all covered > > by frontend checks and neither

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX updated this revision to Diff 86. SouraVX added a comment. Minor refactor for context. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68117/new/ https://reviews.llvm.org/D68117 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/dbg-info-all-calls-described.cp

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX marked 2 inline comments as done. SouraVX added a comment. In D68117#1686235 , @aprantl wrote: > This needs a lot more test coverage: The frontend cases aren't all covered by > frontend checks and neither is the dwarf output. Do you mean to add

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

aprantl added a comment. This needs a lot more test coverage: The frontend cases aren't all covered by frontend checks and neither is the dwarf output. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68117/new/ https://reviews.llvm.org/D68117 __

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

aprantl added a comment. Thanks, this looks like a good addition! Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1608 + if (CGM.getCodeGenOpts().DwarfVersion >= 5) { +// DWARF-5 support for, defaulted, deleted member functions Please try to always upload

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX updated this revision to Diff 222079. SouraVX added a comment. Minor refactor. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68117/new/ https://reviews.llvm.org/D68117 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/dbg-info-all-calls-described.cpp llvm/inc

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX created this revision. SouraVX added reviewers: aprantl, dblaikie, probinson. SouraVX added projects: LLVM, clang, debug-info. Herald added a subscriber: hiraditya. This patch provides DWARF5 support for C++11 defaulted, deleted member. Added support in clang C++ frontend, llvm, and llvm-