This revision was automatically updated to reflect the committed changes.
ymandel marked an inline comment as done.
Closed by commit rL373593: [libTooling] Add various Stencil combinators for
expressions. (authored by ymandel, committed by ).
Herald added a project: LLVM.
Herald added a subscriber
gribozavr marked an inline comment as done.
gribozavr added inline comments.
Comment at: clang/include/clang/Tooling/Refactoring/Stencil.h:149
/// \returns the source corresponding to the selected range.
StencilPart selection(RangeSelector Selector);
ymandel
ymandel marked an inline comment as done.
ymandel added inline comments.
Comment at: clang/include/clang/Tooling/Refactoring/Stencil.h:149
/// \returns the source corresponding to the selected range.
StencilPart selection(RangeSelector Selector);
gribozavr wr
gribozavr added inline comments.
Comment at: clang/include/clang/Tooling/Refactoring/Stencil.h:149
/// \returns the source corresponding to the selected range.
StencilPart selection(RangeSelector Selector);
ymandel wrote:
> gribozavr wrote:
> > Should the com
ymandel marked an inline comment as done.
ymandel added inline comments.
Comment at: clang/include/clang/Tooling/Refactoring/Stencil.h:149
/// \returns the source corresponding to the selected range.
StencilPart selection(RangeSelector Selector);
gribozavr wr
ymandel updated this revision to Diff 222889.
ymandel marked 2 inline comments as done.
ymandel added a comment.
responded to comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68315/new/
https://reviews.llvm.org/D68315
Files:
clang/include/
gribozavr accepted this revision.
gribozavr added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/include/clang/Tooling/Refactoring/Stencil.h:149
/// \returns the source corresponding to the selected range.
StencilPart selection(RangeSelector
ymandel created this revision.
ymandel added a reviewer: gribozavr.
Herald added a project: clang.
This revision adds three new Stencil combinators:
- `expression`, which idiomatically constructs the source for an expression,
including wrapping the expression's source in parentheses if needed.
-
