[PATCH] D68391: [RISCV] Improve sysroot computation if no GCC install detected

thakis added a comment. nvm, rnk just got to it in https://github.com/llvm/llvm-project/commit/f37b5c800e150ad915c4e0571edd2c92c0160d89 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68391/new/ https://reviews.llvm.org/D68391 ___

[PATCH] D68391: [RISCV] Improve sysroot computation if no GCC install detected

thakis added a comment. Sorry, meant to also paste a link to a failing build: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/11994/steps/stage%201%20check/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68391/new/ https:/

[PATCH] D68391: [RISCV] Improve sysroot computation if no GCC install detected

thakis added a comment. The test seems to fail on Windows, could you take a look and revert if it takes a while to fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68391/new/ https://reviews.llvm.org/D68391 ___

[PATCH] D68391: [RISCV] Improve sysroot computation if no GCC install detected

This revision was automatically updated to reflect the committed changes. Closed by commit rGde61aa3118b9: [RISCV] Improve sysroot computation if no GCC install detected (authored by edward-jones). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68391/

[PATCH] D68391: [RISCV] Improve sysroot computation if no GCC install detected

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. Thanks for the rebase. It looks good, let's get it committed! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68391/new/ https://reviews.llvm.org/D68391 _

[PATCH] D68391: [RISCV] Improve sysroot computation if no GCC install detected

edward-jones updated this revision to Diff 227721. edward-jones added a comment. Rebased, added a comment to explain that this is using the user provided triple instead of the canonical one, and split out the tests requiring a shell into separate files (clang/test/Driver/riscv{32,64}-toolchain-e

[PATCH] D68391: [RISCV] Improve sysroot computation if no GCC install detected

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. Herald added a subscriber: sameer.abuasal. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68391/new/ https://reviews.llvm.org/D68391 __

[PATCH] D68391: [RISCV] Improve sysroot computation if no GCC install detected

lenary added a comment. In D68391#1694622 , @edward-jones wrote: > Rebased and added tests > > I've made this use the Triple from the driver rather than the parsed LLVM > triple, this means the Triple doesn't get normalized which seems like more > desir

[PATCH] D68391: [RISCV] Improve sysroot computation if no GCC install detected

luismarques added a comment. This is indeed an issue that would be nice to fix, I've often been annoyed by clang just defaulting to the root when some misconfiguration occurs. I have to wonder though, this patch only changes the clang RISC-V toolchain driver, but the problem isn't specific to R

[PATCH] D68391: [RISCV] Improve sysroot computation if no GCC install detected

edward-jones updated this revision to Diff 223205. edward-jones added a comment. Herald added subscribers: arichardson, emaste. Herald added a reviewer: espindola. Rebased and added tests I've made this use the Triple from the driver rather than the parsed LLVM triple, this means the Triple does

[PATCH] D68391: [RISCV] Improve sysroot computation if no GCC install detected

edward-jones planned changes to this revision. edward-jones added a comment. I'm reworking this at the moment and adding some tests. Standby! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68391/new/ https://reviews.llvm.org/D68391 __

[PATCH] D68391: [RISCV] Improve sysroot computation if no GCC install detected

edward-jones added a comment. Before falling back to returning the empty string this first looks for a directory with the triple name up one level from the driver. This uses the Triple string in the path, however this Triple has been normalized so even if the user specifies "clang --target=risc

[PATCH] D68391: [RISCV] Improve sysroot computation if no GCC install detected

edward-jones created this revision. Herald added subscribers: cfe-commits, pzheng, simoncook, s.egerton, lenary, Jim, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, zzheng, MaskRay, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, apazos, johnrusso, rbar, asb.