This revision was automatically updated to reflect the committed changes.
Closed by commit rL373929: Fix Calling Convention through aliases (authored by
erichkeane, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D68584?vs=223617&id=223750#toc
Repository:
rL LLVM
CHANGES S
rnk accepted this revision.
rnk added a comment.
lgtm
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68584/new/
https://reviews.llvm.org/D68584
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:251
// Make sure the call and the callee agree on calling convention.
- if (llvm::Function *dtorFn =
- dyn_cast(dtor.ge
erichkeane created this revision.
erichkeane added reviewers: rnk, pcc.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.
r369697 changed the behavior of stripPointerCasts to no longer include
aliases. However, the code in CGDeclCXX.cpp's createAtExitStub counted
on the looking
