[PATCH] D68590: [clangd] Improve hover support for Objective-C

dgoldman updated this revision to Diff 309611. dgoldman added a comment. - Rebase + refactor, sorry for the long delay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68590/new/ https://reviews.llvm.org/D68590 Files: clang-tools-extra/clangd/Hover

[PATCH] D68590: [clangd] Improve hover support for Objective-C

dgoldman added a comment. We'll also want to do something similar for `DocumentSymbols`, see here , which will lead to Objective-C categories showing up as either `(anonymous

[PATCH] D68590: [clangd] Improve hover support for Objective-C

dgoldman marked 3 inline comments as done. dgoldman added a comment. Will revisit this once more critical fixes are in (crash fixes), I'm still not sure where this sort of stuff should belong Comment at: clangd/XRefs.cpp:461 + + OS << (Method->isInstanceMethod() ? '-' : '+')

[PATCH] D68590: [clangd] Improve hover support for Objective-C

kadircet added inline comments. Comment at: clangd/XRefs.cpp:461 + + OS << (Method->isInstanceMethod() ? '-' : '+') + << '[' << Class->getName(); it looks like `DeclPrinter::VisitObjCMethodDecl` already has a similar handling. would it provide value if you p

[PATCH] D68590: [clangd] Improve hover support for Objective-C

sammccall added a comment. Thanks! This generally looks good, just need to find the right home for some of the logic. Comment at: clangd/XRefs.cpp:455 +static std::string getNameForObjCMethod(const ObjCMethodDecl *Method) { + std::string Name; XRefs.cpp isn

[PATCH] D68590: [clangd] Improve hover support for Objective-C

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, jfb, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. - Instead of `AppDelegate::application:didFinishLaunchingWithOptions:` you will now see