[PATCH] D68681: [libc++][test] Miscellaneous MSVC cleanups

CaseyCarter added a comment. In D68681#1702194 , @ldionne wrote: > You have commit access, right? If so, go ahead. Otherwise, LMK and I can > commit this for you. Yes, I apparently still have commit access ;) Thanks! Repository: rG LLVM Github Monor

[PATCH] D68681: [libc++][test] Miscellaneous MSVC cleanups

This revision was automatically updated to reflect the committed changes. Closed by commit rGb2e3c83b0d64: [libc++][test] Miscellaneous MSVC cleanups (authored by CaseyCarter). Herald added a subscriber: christof. Herald added a project: libc++. Changed prior to commit: https://reviews.llvm.org

[PATCH] D68681: [libc++][test] Miscellaneous MSVC cleanups

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. You have commit access, right? If so, go ahead. Otherwise, LMK and I can commit this for you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68681/new/ https://reviews.llvm.org/D686

[PATCH] D68681: [libc++][test] Miscellaneous MSVC cleanups

Quuxplusone added inline comments. Comment at: test/std/containers/unord/unord.map/unord.map.cnstr/deduct.pass.cpp:70 +#pragma warning(disable: 4244) // '%s': conversion from '%s' to '%s', possible loss of data +#endif // TEST_COMPILER_C1XX + CaseyCarter wrote:

[PATCH] D68681: [libc++][test] Miscellaneous MSVC cleanups

CaseyCarter updated this revision to Diff 224092. CaseyCarter edited the summary of this revision. CaseyCarter added a comment. Avoid rather than suppress truncation warnings in `unordered_meow` deduction guide tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68681/new/ https://rev

[PATCH] D68681: [libc++][test] Miscellaneous MSVC cleanups

CaseyCarter added inline comments. Comment at: test/std/containers/unord/unord.map/unord.map.cnstr/deduct.pass.cpp:70 +#pragma warning(disable: 4244) // '%s': conversion from '%s' to '%s', possible loss of data +#endif // TEST_COMPILER_C1XX + Quuxplusone wrote:

[PATCH] D68681: [libc++][test] Miscellaneous MSVC cleanups

Quuxplusone added inline comments. Comment at: test/std/containers/unord/unord.map/unord.map.cnstr/deduct.pass.cpp:70 +#pragma warning(disable: 4244) // '%s': conversion from '%s' to '%s', possible loss of data +#endif // TEST_COMPILER_C1XX + Alternatively, if

[PATCH] D68681: [libc++][test] Miscellaneous MSVC cleanups

CaseyCarter created this revision. CaseyCarter added reviewers: mclow.lists, EricWF, ldionne. Herald added a subscriber: dexonsmith. - Silence unused-local-typedef warnings: `map.cons/assign_initializer_list.pass.cpp` (and the `set.cons` variant) uses a local typedef only within `LIBCPP_ASSERT`s