[PATCH] D68756: [libc++][test] Change IsSmallObject's calculation for std::any's small object buffer

2019-10-10 Thread Casey Carter via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGffc83995de6d: [libc++][test] Change IsSmallObject's calculation for std::any's small object… (authored by CaseyCarter). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D68756: [libc++][test] Change IsSmallObject's calculation for std::any's small object buffer

2019-10-10 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF accepted this revision. EricWF added inline comments. This revision is now accepted and ready to land. Comment at: libcxx/test/support/any_helpers.h:30 {}; template bool containsType(std::any const& a) { LGTM. Repository: rG LLVM Github Monorepo

[PATCH] D68756: [libc++][test] Change IsSmallObject's calculation for std::any's small object buffer

2019-10-09 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter marked an inline comment as done. CaseyCarter added inline comments. Comment at: libcxx/test/support/any_helpers.h:24 : public std::integral_constant::value I have no idea why this line is highlighted: there are no changes on this line in the di

[PATCH] D68756: [libc++][test] Change IsSmallObject's calculation for std::any's small object buffer

2019-10-09 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter created this revision. CaseyCarter added reviewers: mclow.lists, EricWF, ldionne. CaseyCarter added a project: libc++. Herald added subscribers: libcxx-commits, dexonsmith, christof. `sizeof(std::any) - sizeof(void*)` is correct for both libc++ and the MSVC standard library. Reposit