[PATCH] D68981: [clangd] Use our own relation kind.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc8e3f43ab514: [clangd] Use our own relation kind. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68981/new/ https://reviews.llvm.org/D6

[PATCH] D68981: [clangd] Use our own relation kind.

merge_guards_bot added a comment. Bulid results are available at http://results.llvm-merge-guard.org/Phabricator-42 See http://jenkins.llvm-merge-guard.org/job/Phabricator/42/ for more details. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68981

[PATCH] D68981: [clangd] Use our own relation kind.

merge_guards_bot added a comment. Bulid results are available at http://results.llvm-merge-guard.org/Phabricator-43 See http://jenkins.llvm-merge-guard.org/job/Phabricator/43/ for more details. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68981

[PATCH] D68981: [clangd] Use our own relation kind.

merge_guards_bot added a comment. Bulid results are available at http://results.llvm-merge-guard.org/Phabricator-41 See http://jenkins.llvm-merge-guard.org/job/Phabricator/41/ for more details. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68981

[PATCH] D68981: [clangd] Use our own relation kind.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68981/new/ https://reviews.llvm.org/D68981 ___

[PATCH] D68981: [clangd] Use our own relation kind.

hokein updated this revision to Diff 225041. hokein added a comment. more static_cast Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68981/new/ https://reviews.llvm.org/D68981 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-extra/clangd/i

[PATCH] D68981: [clangd] Use our own relation kind.

merge_guards_bot added a comment. Bulid results are available at http://results.llvm-merge-guard.org/Phabricator-40 See http://jenkins.llvm-merge-guard.org/job/Phabricator/40/ for more details. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68981

[PATCH] D68981: [clangd] Use our own relation kind.

hokein updated this revision to Diff 225039. hokein added a comment. fix a missing static_cast. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68981/new/ https://reviews.llvm.org/D68981 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-extr

[PATCH] D68981: [clangd] Use our own relation kind.

hokein updated this revision to Diff 225037. hokein marked 5 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68981/new/ https://reviews.llvm.org/D68981 Files: clang-tools-extra/cla

[PATCH] D68981: [clangd] Use our own relation kind.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/MemIndex.cpp:95 LookupRequest LookupReq; -auto It = Relations.find(std::make_pair(Subject, Req.Predicate)); +auto It = Relations.find(std::make_pair(Subject, (uint8_t)Req.Predicate)); if

[PATCH] D68981: [clangd] Use our own relation kind.

hokein added inline comments. Comment at: clang-tools-extra/clangd/index/MemIndex.h:72 // A map from (subject, predicate) pair to objects. - llvm::DenseMap, std::vector> + llvm::DenseMap, std::vector> Relations; kadircet wrote: > can we rather use `ui

[PATCH] D68981: [clangd] Use our own relation kind.

hokein updated this revision to Diff 225034. hokein marked 4 inline comments as done. hokein added a comment. Herald added subscribers: llvm-commits, dexonsmith. Herald added a project: LLVM. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D68981: [clangd] Use our own relation kind.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/MemIndex.h:72 // A map from (subject, predicate) pair to objects. - llvm::DenseMap, std::vector> + llvm::DenseMap, std::vector> Relations; can we rather use `uint8_t` in here i

[PATCH] D68981: [clangd] Use our own relation kind.

merge_guards_bot added a comment. Bulid results are available at http://results.llvm-merge-guard.org/Phabricator-38 See http://jenkins.llvm-merge-guard.org/job/Phabricator/38/ for more details. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68981

[PATCH] D68981: [clangd] Use our own relation kind.

hokein updated this revision to Diff 225017. hokein added a comment. update a style comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68981/new/ https://reviews.llvm.org/D68981 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-extra/c

[PATCH] D68981: [clangd] Use our own relation kind.

merge_guards_bot added a comment. Bulid results are available at http://results.llvm-merge-guard.org/Phabricator-37 See http://jenkins.llvm-merge-guard.org/job/Phabricator/37/ for more details. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68981

[PATCH] D68981: [clangd] Use our own relation kind.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Move the RelationKind from Serialization.h to Relation.h. This patch doesn't introduce any breaking changes. Repository: