This revision was automatically updated to reflect the committed changes.
Closed by commit rG930ada91ce8f: Replace platform-dependent `stat` with
`llvm::sys::fs::status`. NFC intended. (authored by vsapsai).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
vsapsai added a comment.
Thanks for the review! If `fs::status` behaviour is sufficiently different on
Windows, it is worth fixing because I believe majority of non-Windows
developers expect them to work in the same way.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69011/new/
https:/
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Watching for regressions in stat calls sounds really useful.
This change is trivially equivalent on linux, but the code path is quite
different on windows (I have no idea how ::stat work
vsapsai created this revision.
vsapsai added reviewers: bruno, sammccall.
Herald added subscribers: ributzka, arphaman, dexonsmith, jkorous.
vsapsai added a comment.
The plan is to instrument `llvm::sys::fs::status` with
`ALWAYS_ENABLED_STATITSTIC` to be able to catch regressions causing lots of
vsapsai added a comment.
The plan is to instrument `llvm::sys::fs::status` with
`ALWAYS_ENABLED_STATITSTIC` to be able to catch regressions causing lots of
`stat` calls. That's why replacing current `stat` calls. And it seems to be a
good change regardless of future plans.
CHANGES SINCE LAST
