[PATCH] D69164: [clang-format] fix regression recognizing casts in Obj-C calls

2019-10-19 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. rC373922: [clang-format] [PR27004] omits leading space for noexcept when formatting… was to fix https://bugs.llvm.org/show_bug.cgi?id=27004 which wasn't just related to `delete` it occurred in other cases. (operator++) and ther

[PATCH] D69164: [clang-format] fix regression recognizing casts in Obj-C calls

2019-10-18 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir marked an inline comment as done. krasimir added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:1612 + Keywords.kw_final) || +isCpp11AttributeSpecifier(*Tok.Next)) return false; rdwampler wrote: > I thi

[PATCH] D69164: [clang-format] fix regression recognizing casts in Obj-C calls

2019-10-18 Thread Krasimir Georgiev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGeff2a2ab2b51: [clang-format] fix regression recognizing casts in Obj-C calls (authored by krasimir). Changed prior to commit: https://reviews.llvm.org/D69164?vs=225604&id=225635#toc Repository: rG LL

[PATCH] D69164: [clang-format] fix regression recognizing casts in Obj-C calls

2019-10-18 Thread Ronald Wampler via Phabricator via cfe-commits
rdwampler added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:1612 + Keywords.kw_final) || +isCpp11AttributeSpecifier(*Tok.Next)) return false; I think the issue r373922 was fixing is only related to the `delet

[PATCH] D69164: [clang-format] fix regression recognizing casts in Obj-C calls

2019-10-18 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. LGTM, thanks for the patch Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69164/new/ https://reviews.llvm.org/D69164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D69164: [clang-format] fix regression recognizing casts in Obj-C calls

2019-10-18 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. krasimir edited the summary of this revision. krasimir added a reviewer: MyDeveloperDay. r373922 added checks for a few tokens that, following an `)` make it unlikely that the `)` is the closing