[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

morehouse added inline comments. Comment at: clang/tools/clang-fuzzer/ClangObjectiveCFuzzer.cpp:19 -extern "C" int LLVMFuzzerInitialize(int *argc, char ***argv) { return 0; } - RKSimon wrote: > @dgoldman @morehouse Removing this has been causing link failures

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

RKSimon added inline comments. Comment at: clang/tools/clang-fuzzer/ClangObjectiveCFuzzer.cpp:19 -extern "C" int LLVMFuzzerInitialize(int *argc, char ***argv) { return 0; } - @dgoldman @morehouse Removing this has been causing link failures ever since it was

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

gribozavr added a comment. Looks reasonable to me. The duplication is unfortunate, but it is reasonable while we have two binaries. However, you could explore reading the command line flags for HandleCXX in LLVMFuzzerInitialize from fuzzer's command line flags. Repository: rG LLVM Github

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

This revision was automatically updated to reflect the committed changes. dgoldman marked an inline comment as done. Closed by commit rGe5ecba4f53e7: [clang-fuzzer] Add new fuzzer target for Objective-C (authored by dgoldman). Changed prior to commit:

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

morehouse accepted this revision. morehouse added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69171/new/ https://reviews.llvm.org/D69171 ___

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

dgoldman updated this revision to Diff 225899. dgoldman added a comment. - Swap to reinterpret_cast Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69171/new/ https://reviews.llvm.org/D69171 Files: tools/clang-fuzzer/CMakeLists.txt

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

dgoldman marked 4 inline comments as done. dgoldman added inline comments. Comment at: tools/clang-fuzzer/handle-objc/handle_objc.cpp:50 +); +} + morehouse wrote: > Since this is ~identical to handle_cxx, I'd like to reuse the

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

dgoldman updated this revision to Diff 225898. dgoldman added a comment. - Refactor to use handle-cxx Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69171/new/ https://reviews.llvm.org/D69171 Files: tools/clang-fuzzer/CMakeLists.txt

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

morehouse added inline comments. Comment at: tools/clang-fuzzer/ClangObjectiveCFuzzer.cpp:19 + +extern "C" int LLVMFuzzerInitialize(int *argc, char ***argv) { return 0; } + Nit: Since it does nothing, let's omit the `LLVMFuzzerInitialize` definition.

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

dgoldman added a comment. Not sure who is best to review, feel free to add someone else instead. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69171/new/ https://reviews.llvm.org/D69171 ___ cfe-commits mailing list

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

dgoldman added a comment. In D69171#1714624 , @sammccall wrote: > Rather than adding a new fuzzer binary, can we make the language an option? > The whole implementation seems almost identical down to > handleobjc/handlecxx... It's similar at the

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

sammccall added a comment. Rather than adding a new fuzzer binary, can we make the language an option? The whole implementation seems almost identical down to handleobjc/handlecxx... Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69171/new/

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

dgoldman created this revision. Herald added subscribers: cfe-commits, jfb, mgorny. Herald added a project: clang. - Similar to that of `clang-fuzzer` itself but instead only targets Objective-C source files via cc1 - Also adds an example corpus directory containing some input for Objective-C