[PATCH] D69221: [clang][darwin] Fix search path logic for C_INCLUDE_DIRS

This revision was automatically updated to reflect the committed changes. Closed by commit rG6fa3894c4e77: [clang] Fix search path logic for C_INCLUDE_DIRS (authored by ldionne). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69221/new/ https://revie

[PATCH] D69221: [clang][darwin] Fix search path logic for C_INCLUDE_DIRS

mhinz added a comment. In D69221#1848425 , @ldionne wrote: > Do you have commit access? No. :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69221/new/ https://reviews.llvm.org/D69221 ___ cfe-comm

[PATCH] D69221: [clang][darwin] Fix search path logic for C_INCLUDE_DIRS

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. Do you have commit access? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69221/new/ https://reviews.llvm.org/D69221 ___ cfe-commits ma

[PATCH] D69221: [clang][darwin] Fix search path logic for C_INCLUDE_DIRS

mhinz added a comment. I applied the fix to all toolchains now, but I'm unsure how to write a test for it. Neither could I find tests for similar options like `-DDEFAULT_SYSROOT`. My use case: I want to build a clang that has the same search path as the clang shipped with macOS. $ /usr/bin/c

[PATCH] D69221: [clang][darwin] Fix search path logic for C_INCLUDE_DIRS

mhinz updated this revision to Diff 231266. mhinz added a comment. Herald added subscribers: aheejin, jgravelle-google, sbc100, dschuff. Apply fix to all toolchains. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69221/new/ https://reviews.llvm.org/D69221 Files: clang/lib/Driver/ToolC

[PATCH] D69221: [clang][darwin] Fix search path logic for C_INCLUDE_DIRS

ldionne requested changes to this revision. ldionne added a comment. This revision now requires changes to proceed. Good find! The following drivers (at least) appear to have the same problem: clang/lib/Driver/ToolChains/WebAssembly.cpp:236 clang/lib/Driver/ToolChains/Solaris.cpp:247 clang/

[PATCH] D69221: [clang][darwin] Fix search path logic for C_INCLUDE_DIRS

mhinz created this revision. mhinz added reviewers: ldionne, rsmith. mhinz added a project: clang. Herald added subscribers: cfe-commits, dexonsmith. For each absolute path given to C_INCLUDE_DIRS, we want it to be added as-is to the include search path. Relative paths should be prefixed with the