[PATCH] D69241: [clangd] Handle the missing consturctor initializers in findExplicitReferences.

ilya-biryukov added a comment. NIT: there's a typo in the revision title: should be **constructor**, not **consturctor** Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69241/new/ https://reviews.llvm.org/D69241

[PATCH] D69241: [clangd] Handle the missing consturctor initializers in findExplicitReferences.

merge_guards_bot added a comment. Build result: fail - 33623 tests passed, 1 failed and 462 were skipped. failed: LLVM.tools/llvm-ar/mri-utf8.test Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D69241: [clangd] Handle the missing consturctor initializers in findExplicitReferences.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang-tools-extra/clangd/FindTarget.cpp:646 + bool TraverseConstructorInitializer(CXXCtorInitializer *Init) { +

[PATCH] D69241: [clangd] Handle the missing consturctor initializers in findExplicitReferences.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:844 +int $1^abc; +$2^X(): $3^abc() {} + }; Could you also add a test with the initializer containing a base

[PATCH] D69241: [clangd] Handle the missing consturctor initializers in findExplicitReferences.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69241 Files: clang-tools-extra/clangd/FindTarget.cpp