This revision was automatically updated to reflect the committed changes.
Closed by commit rGa45f713c6730: add option to instantiate templates already in
the PCH (authored by llunak).
Changed prior to commit:
https://reviews.llvm.org/D69585?vs=265918=272312#toc
Repository:
rG LLVM Github
llunak updated this revision to Diff 265918.
llunak edited the summary of this revision.
llunak added a comment.
Enabled the option by default for clang-cl to match MSVC.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69585/new/
https://reviews.llvm.org/D69585
llunak marked an inline comment as done.
llunak added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5610
+ if (Args.hasFlag(options::OPT_fpch_instantiate_templates,
+ options::OPT_fno_pch_instantiate_templates, false))
+
rnk added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5610
+ if (Args.hasFlag(options::OPT_fpch_instantiate_templates,
+ options::OPT_fno_pch_instantiate_templates, false))
+CmdArgs.push_back("-fpch-instantiate-templates");
llunak marked an inline comment as done.
llunak added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5610
+ if (Args.hasFlag(options::OPT_fpch_instantiate_templates,
+ options::OPT_fno_pch_instantiate_templates, false))
+
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
IMO there is a pretty clear performance use case for this mode of operation,
and it seems to me that you have addressed @rsmith's feedback. Please wait a
few days to see if he has more to
llunak added a comment.
Ping.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69585/new/
https://reviews.llvm.org/D69585
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
llunak added a comment.
Ping.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69585/new/
https://reviews.llvm.org/D69585
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
llunak updated this revision to Diff 258605.
llunak retitled this revision from "PerformPendingInstatiations() already in
the PCH" to "Add option to instantiate templates already in the PCH".
llunak edited the summary of this revision.
llunak added a comment.
Changed to use
