[PATCH] D69598: Work on cleaning up denormal mode handling

arsenm closed this revision. arsenm added a comment. 7fe9435dc88050ee78eb1d4adec87610dce468f7 This does now need to be merged with the FPEnv.h header CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69598/new/ https://

[PATCH] D69598: Work on cleaning up denormal mode handling

arsenm added a comment. In D69598#1742740 , @andrew.w.kaylor wrote: > Thanks. I understand your direction for denormal handling now, and I'm OK > with this patch apart from the remaining references to subnormal that Sanjay > mentioned. > > In D69598#173

[PATCH] D69598: Work on cleaning up denormal mode handling

andrew.w.kaylor accepted this revision. andrew.w.kaylor added a comment. Thanks. I understand your direction for denormal handling now, and I'm OK with this patch apart from the remaining references to subnormal that Sanjay mentioned. In D69598#1739723 ,

[PATCH] D69598: Work on cleaning up denormal mode handling

arsenm marked an inline comment as done. arsenm added a comment. In D69598#1739655 , @andrew.w.kaylor wrote: > I'm unclear as to the expectations surrounding this option. I suppose this is > somewhat beyond the scope of the current changes, but I'm confu

[PATCH] D69598: Work on cleaning up denormal mode handling

andrew.w.kaylor added a comment. I'm unclear as to the expectations surrounding this option. I suppose this is somewhat beyond the scope of the current changes, but I'm confused by clang's current behavior with regard to denormals. The -fdenromal-fp-math option causes a function attribute to be

[PATCH] D69598: Work on cleaning up denormal mode handling

spatel accepted this revision. spatel added a comment. This revision is now accepted and ready to land. LGTM - see inline for some leftover naming diffs. Comment at: clang/lib/CodeGen/CGCall.cpp:1744-1745 FuncAttrs.addAttribute("null-pointer-is-valid", "true"); -if (

[PATCH] D69598: Work on cleaning up denormal mode handling

arsenm updated this revision to Diff 228168. arsenm added a comment. Missed a spot to rename CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69598/new/ https://reviews.llvm.org/D69598 Files: clang/include/clang/Basic/CodeGenOptions.h clang/lib/CodeGen/CGCall.cpp clang/lib/Frontend/

[PATCH] D69598: Work on cleaning up denormal mode handling

arsenm marked an inline comment as done. arsenm added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1736-1737 +if (CodeGenOpts.FPSubnormalMode != llvm::SubnormalMode::Invalid) + FuncAttrs.addAttribute("denormal-fp-math", + llvm::s

[PATCH] D69598: Work on cleaning up denormal mode handling

arsenm updated this revision to Diff 228161. arsenm added a comment. Rename to denormal CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69598/new/ https://reviews.llvm.org/D69598 Files: clang/include/clang/Basic/CodeGenOptions.h clang/lib/CodeGen/CGCall.cpp clang/lib/Frontend/Compi

[PATCH] D69598: Work on cleaning up denormal mode handling

spatel added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1736-1737 +if (CodeGenOpts.FPSubnormalMode != llvm::SubnormalMode::Invalid) + FuncAttrs.addAttribute("denormal-fp-math", + llvm::subnormalModeName(CodeGenOpts.FPSubnormalM

[PATCH] D69598: Work on cleaning up denormal mode handling

arsenm marked an inline comment as done. arsenm added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1736-1737 +if (CodeGenOpts.FPSubnormalMode != llvm::SubnormalMode::Invalid) + FuncAttrs.addAttribute("denormal-fp-math", + llvm::s

[PATCH] D69598: Work on cleaning up denormal mode handling

spatel added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1736-1737 +if (CodeGenOpts.FPSubnormalMode != llvm::SubnormalMode::Invalid) + FuncAttrs.addAttribute("denormal-fp-math", + llvm::subnormalModeName(CodeGenOpts.FPSubnormalM

[PATCH] D69598: Work on cleaning up denormal mode handling

arsenm marked an inline comment as done. arsenm added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1736-1737 +if (CodeGenOpts.FPSubnormalMode != llvm::SubnormalMode::Invalid) + FuncAttrs.addAttribute("denormal-fp-math", + llvm::s

[PATCH] D69598: Work on cleaning up denormal mode handling

spatel added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1736-1737 +if (CodeGenOpts.FPSubnormalMode != llvm::SubnormalMode::Invalid) + FuncAttrs.addAttribute("denormal-fp-math", + llvm::subnormalModeName(CodeGenOpts.FPSubnormalM

[PATCH] D69598: Work on cleaning up denormal mode handling

arsenm updated this revision to Diff 227775. arsenm retitled this revision from "WIP: Work on cleaning up denormal mode handling" to "Work on cleaning up denormal mode handling". arsenm added a comment. Defer any behavior changes until a future patch, so all tests now pass CHANGES SINCE LAST AC