[PATCH] D69615: [clangd] Implement a function to lex the file to find candidate occurrences.

merge_guards_bot added a comment. Build result: fail - 59859 tests passed, 22 failed and 763 were skipped. failed: libc++.std/thread/thread_mutex/thread_mutex_requirements/thread_mutex_requirements_mutex/thread_mutex_class/try_lock.pass.cpp failed: lld.ELF/linkerscript/filename-spec.s fail

[PATCH] D69615: [clangd] Implement a function to lex the file to find candidate occurrences.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ea4c6fa5121: [clangd] Implement a function to lex the file to find candidate occurrences. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D69615: [clangd] Implement a function to lex the file to find candidate occurrences.

hokein updated this revision to Diff 228011. hokein marked an inline comment as done. hokein added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69615/new/ https://reviews.llvm.org/D69615 Files: clang-tools-extra/clan

[PATCH] D69615: [clangd] Implement a function to lex the file to find candidate occurrences.

ilya-biryukov accepted this revision. ilya-biryukov added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/SourceCode.cpp:757 + lex(Content, LangOpts, [&](const clang::Token &Tok, const SourceManager &SM) { +if (Tok.getK

[PATCH] D69615: [clangd] Implement a function to lex the file to find candidate occurrences.

merge_guards_bot added a comment. Build result: pass - 59741 tests passed, 0 failed and 762 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D69615: [clangd] Implement a function to lex the file to find candidate occurrences.

hokein added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:769 +llvm::StringRef TokenName; +if (Tok.getKind() == tok::identifier) + TokenName = Tok.getIdentifierInfo()->getName(); ilya-biryukov wrote: > Why do we ha

[PATCH] D69615: [clangd] Implement a function to lex the file to find candidate occurrences.

hokein updated this revision to Diff 227877. hokein marked 4 inline comments as done. hokein added a comment. address comments, and simplify the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69615/new/ https://reviews.llvm.org/D69615 Files:

[PATCH] D69615: [clangd] Implement a function to lex the file to find candidate occurrences.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:769 +llvm::StringRef TokenName; +if (Tok.getKind() == tok::identifier) + TokenName = Tok.getIdentifierInfo()->getName(); Why do we have both `raw_ide

[PATCH] D69615: [clangd] Implement a function to lex the file to find candidate occurrences.

merge_guards_bot added a comment. Build result: pass - 59741 tests passed, 0 failed and 762 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D69615: [clangd] Implement a function to lex the file to find candidate occurrences.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. This will be used for incoming cross-file rename (to detect index staleness issue). Repository: rG LLVM Github Monorep