[PATCH] D69743: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood

This revision was automatically updated to reflect the committed changes. Closed by commit rGa5c8ec4baa2c: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood (authored by vsk). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69743: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood

dblaikie added a comment. In D69743#1733101 , @vsk wrote: > In D69743#1732967 , @dblaikie wrote: > > > What's the extra DWARF that's emitted from the backend? Is there a > > corresponding LLVM code change/test, or

[PATCH] D69743: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood

vsk added a comment. In D69743#1732967 , @dblaikie wrote: > What's the extra DWARF that's emitted from the backend? Is there a > corresponding LLVM code change/test, or is the functionality there but > dormant in this particular case? (& already

[PATCH] D69743: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood

vsk updated this revision to Diff 227774. vsk edited the summary of this revision. vsk added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. - Add coverage for a callee without a subprogram in llvm/test/DebugInfo/X86/dwarf-callsite-related-attrs.ll. CHANGES

[PATCH] D69743: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood

dblaikie added a comment. What's the extra DWARF that's emitted from the backend? Is there a corresponding LLVM code change/test, or is the functionality there but dormant in this particular case? (& already running/tested in other cases, such as when fn1 is defined in the same CU) CHANGES

[PATCH] D69743: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood

djtodoro accepted this revision. djtodoro added a comment. This revision is now accepted and ready to land. @vsk Thanks for this! (lgtm) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69743/new/ https://reviews.llvm.org/D69743 ___

[PATCH] D69743: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood

vsk created this revision. vsk added reviewers: aprantl, djtodoro, dblaikie. Currently, clang emits subprograms for declared functions when the target debugger or DWARF standard is known to support entry values (DW_OP_entry_value & the GNU equivalent). Expand this behavior to include debuggers