[PATCH] D69745: [analyzer] Checker: check::BeginAnalysis

NoQ added a comment. In D69745#1732744 , @Charusso wrote: > I think every `UnknownSpaceRegion` stuff is tainted, and that is a strong > mark here. Mmm, no, that's definitely not true. Basically, if you analyze a method of a class as your top frame, you

[PATCH] D69745: [analyzer] Checker: check::BeginAnalysis

Charusso abandoned this revision. Charusso marked an inline comment as done. Charusso added a comment. In D69745#1732739 , @NoQ wrote: > Basically this, but the other way round: your `BeginAnalysis` is > `BeginFunction` with extra steps (namely, checking

[PATCH] D69745: [analyzer] Checker: check::BeginAnalysis

NoQ added a comment. > I think we need to merge the `BeginFunction` into the `BeginWorklist`. Basically this, but the other way round: your `BeginAnalysis` is `BeginFunction` with extra steps (namely, checking `C.inTopFrame()`). Backstory: I wanted to add `BeginAnalysis` a few years ago because

[PATCH] D69745: [analyzer] Checker: check::BeginAnalysis

Charusso marked 3 inline comments as done. Charusso added a comment. In D69745#1732348 , @Szelethus wrote: > YES PLEASE. Debug checkers that only dump from `check::EndAnalysis` won't > rely on the analysis not actually crashing. Which is ironically exactl

[PATCH] D69745: [analyzer] Checker: check::BeginAnalysis

Charusso updated this revision to Diff 227710. Charusso edited the summary of this revision. Charusso added a comment. - Do not restrict what you supposed to do with the callback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69745/new/ https://reviews.llvm.org/D69745 Files: clang/in

[PATCH] D69745: [analyzer] Checker: check::BeginAnalysis

Szelethus added a comment. YES PLEASE. Debug checkers that only dump from `check::EndAnalysis` won't rely on the analysis not actually crashing. Which is ironically exactly when we want to use them. Comment at: clang/lib/StaticAnalyzer/Checkers/CheckerDocumentation.cpp:199 +

[PATCH] D69745: [analyzer] Checker: check::BeginAnalysis

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CheckerDocumentation.cpp:199 + /// + /// This callback should be used to construct the checker's fields. + /// Szelethus wrote: > Hmmm, what use case do you have in mind? Do we actu

[PATCH] D69745: [analyzer] Checker: check::BeginAnalysis

Charusso marked an inline comment as done. Charusso added a comment. I felt that it will be easier, eh. Comment at: clang/lib/StaticAnalyzer/Core/CoreEngine.cpp:118 +SubEng.processBeginWorklist(BuilderCtx, Node, DstBegin, StartLoc); SubEng.processBeginOfFunction(Builde

[PATCH] D69745: [analyzer] Checker: check::BeginAnalysis

Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Charusso added a parent revision: D69731: [analyzer] CheckerCont