[PATCH] D69810: [OpenCL] Fix address space for base method call (PR43145)

This revision was automatically updated to reflect the committed changes. Closed by commit rG35388dcbbc4c: [OpenCL] Fix address space for base method call (PR43145) (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69810/new/ https

[PATCH] D69810: [OpenCL] Fix address space for base method call (PR43145)

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69810/new/ https://reviews.llvm.org/D69810 ___ cfe-commits mailing list cfe-comm

[PATCH] D69810: [OpenCL] Fix address space for base method call (PR43145)

svenvh updated this revision to Diff 230278. svenvh added a comment. Incorporate suggestions from @rjmccall and add a test for the pointer case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69810/new/ https://reviews.llvm.org/D69810 Files: clang/lib/Sema/SemaExpr.cpp clang/test/Co

[PATCH] D69810: [OpenCL] Fix address space for base method call (PR43145)

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:2721 + From = ImpCastExprToType(From, DestASTy, CK_AddressSpaceConversion, + From->getValueKind()).get(); +} Both the source and dest types here are off

[PATCH] D69810: [OpenCL] Fix address space for base method call (PR43145)

svenvh updated this revision to Diff 230096. svenvh edited the summary of this revision. svenvh added a comment. Rework fix to insert an addrspace conversion node into the AST instead of catching the addrspace cast in CGCall. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69810/new/ htt

[PATCH] D69810: [OpenCL] Fix address space for base method call (PR43145)

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:4091 +V = Builder.CreatePointerBitCastOrAddrSpaceCast( +V, IRFuncTy->getParamType(FirstIRArg)); + else Anastasia wrote: > svenvh wrote: > > @Anastasia po

[PATCH] D69810: [OpenCL] Fix address space for base method call (PR43145)

Anastasia added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:4091 +V = Builder.CreatePointerBitCastOrAddrSpaceCast( +V, IRFuncTy->getParamType(FirstIRArg)); + else svenvh wrote: > @Anastasia pointed out that the A

[PATCH] D69810: [OpenCL] Fix address space for base method call (PR43145)

svenvh marked an inline comment as done. svenvh added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:4091 +V = Builder.CreatePointerBitCastOrAddrSpaceCast( +V, IRFuncTy->getParamType(FirstIRArg)); + else @Anastasia

[PATCH] D69810: [OpenCL] Fix address space for base method call (PR43145)

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added subscribers: cfe-commits, ebevhan, yaxunl. Herald added a project: clang. Potentially create an addrspacecast in case the argument is a pointer. Repository: rC Clang https://reviews.llvm.org/D69810 Files: clang/