This revision was automatically updated to reflect the committed changes.
Closed by commit rG1d40c4150630: [clang-tools-extra] fix the check for if
'-latomic' is necessary (authored by gokturk, committed by
luismarques).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://
luismarques accepted this revision.
luismarques added a comment.
This revision is now accepted and ready to land.
Whether or not GCC behaves the way it should behave regarding atomics, this
seems like a sensible patch to make things work given the current situation.
LGTM.
Repository:
rG LLVM
gokturk added a comment.
ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69869/new/
https://reviews.llvm.org/D69869
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
gokturk added a comment.
Let me try my best to explain what's happening. The goal of this check is to
determine whether passing `-latomic` is required.
Let's start with the code used by `check_working_cxx_atomics64`
(https://github.com/llvm/llvm-project/blob/master/llvm/cmake/modules/CheckAtomi
compnerd added a comment.
I agree with @efriedma that it sounds odd, could you explain that please?
It took about 3 reads before I saw the OUT in the WITHOUT, and then realized
that this was just: `NOT (HAVE_CXX_ATOMICS_WITHOUT_LIB AND
HAVE_CXX_ATOMICS64_WITHOUT_LIB)`. I don't know if there is
efriedma added a comment.
> while failing on 8-bit atomic operations as there is no hardware support
That's weird; it should be possible to emulate 8-bit atomic operations on top
of 64-bit cmpxchg.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D698
gokturk created this revision.
gokturk added reviewers: ilya-biryukov, nridge, kadircet, beanz, compnerd.
Herald added subscribers: cfe-commits, usaxena95, s.egerton, lenary, PkmX, jfb,
arphaman, jkorous, simoncook, mgorny.
Herald added a project: clang.
The CheckAtomic module performs two tests
