kmclaughlin added inline comments.
Comment at:
llvm/test/CodeGen/AArch64/sve2-intrinsics-fp-int-binary-logarithm.ll:31
+; CHECK-NEXT: ret
+ %out = call @llvm.aarch64.sve.flogb.nxv2f64( %a,
+ %pg,
Allen added inline comments.
Herald added a project: All.
Comment at:
llvm/test/CodeGen/AArch64/sve2-intrinsics-fp-int-binary-logarithm.ll:31
+; CHECK-NEXT: ret
+ %out = call @llvm.aarch64.sve.flogb.nxv2f64( %a,
+
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8881ac9c3986: [AArch64][SVE2] Implement remaining SVE2
floating-point intrinsics (authored by kmclaughlin).
Changed prior to commit:
https://reviews.llvm.org/D70253?vs=229341=231886#toc
Repository:
sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.
Thanks @kmclaughlin , LGTM.
Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:898
+ llvm_i32_ty],
+[IntrNoMem]>;
+
kmclaughlin added inline comments.
Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:898
+ llvm_i32_ty],
+[IntrNoMem]>;
+
sdesmalen wrote:
> efriedma wrote:
> > kmclaughlin wrote:
> > > sdesmalen wrote:
> > > > I'd expect the
sdesmalen added inline comments.
Herald added a reviewer: efriedma.
Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:898
+ llvm_i32_ty],
+[IntrNoMem]>;
+
efriedma wrote:
> kmclaughlin wrote:
> > sdesmalen wrote:
> > > I'd
efriedma added inline comments.
Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:898
+ llvm_i32_ty],
+[IntrNoMem]>;
+
kmclaughlin wrote:
> sdesmalen wrote:
> > I'd expect the `llvm_i32_ty` to be an immediate for these
kmclaughlin added inline comments.
Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:898
+ llvm_i32_ty],
+[IntrNoMem]>;
+
sdesmalen wrote:
> I'd expect the `llvm_i32_ty` to be an immediate for these instructions,
> right? If
sdesmalen added inline comments.
Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:898
+ llvm_i32_ty],
+[IntrNoMem]>;
+
I'd expect the `llvm_i32_ty` to be an immediate for these instructions, right?
If so you'll need to add
kmclaughlin created this revision.
kmclaughlin added reviewers: huntergr, sdesmalen, dancgr.
Herald added subscribers: hiraditya, kristof.beyls, tschuett.
Herald added a project: LLVM.
Adds the following intrinsics:
- faddp
- fmaxp, fminp, fmaxnmp & fminnmp
- fmlalb, fmlalt, fmlslb & fmlslt
-
10 matches
Mail list logo