[PATCH] D70357: [clangd] Untangle Hover from XRefs, move into own file.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Hover.cpp:374 + } else { +auto Offset = positionToOffset(SM.getBufferData(SM.getMainFileID()), Pos); +if (!Offset) {

[PATCH] D70357: [clangd] Untangle Hover from XRefs, move into own file.

sammccall marked 4 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:374 + } else { +auto Offset = positionToOffset(SM.getBufferData(SM.getMainFileID()), Pos); +if (!Offset) { kadircet wrote: >

[PATCH] D70357: [clangd] Untangle Hover from XRefs, move into own file.

kuhnel added a comment. I had a look at the build problems: https://github.com/google/llvm-premerge-checks/issues/56 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70357/new/ https://reviews.llvm.org/D70357

[PATCH] D70357: [clangd] Untangle Hover from XRefs, move into own file.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:374 + } else { +auto Offset = positionToOffset(SM.getBufferData(SM.getMainFileID()), Pos); +if (!Offset) { nit: `SM.getFileOffset(SourceLocationBeg)` ?

[PATCH] D70357: [clangd] Untangle Hover from XRefs, move into own file.

sammccall added a subscriber: kuhnel. sammccall added a comment. @kuhnel: I think the premerge guards bot is acting up here: the first snapshot was definitely broken (missing files). And even the second the ninja logs don't show building the new files. I think it might just be building the tree

[PATCH] D70357: [clangd] Untangle Hover from XRefs, move into own file.

merge_guards_bot added a comment. Build result: pass - 60143 tests passed, 0 failed and 729 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70357: [clangd] Untangle Hover from XRefs, move into own file.

merge_guards_bot added a comment. Build result: pass - 60143 tests passed, 0 failed and 729 were skipped. Log files: console-log.txt , CMakeCache.txt