[PATCH] D70603: Change while to do-while

2020-06-25 Thread Seija Kijin via Phabricator via cfe-commits
pi1024e added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70603/new/ https://reviews.llvm.org/D70603 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[PATCH] D70603: Change while to do-while

2020-06-25 Thread Seija Kijin via Phabricator via cfe-commits
pi1024e added a comment. How do I do that, if I may ask? Sorry for the rude tone. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70603/new/ https://reviews.llvm.org/D70603 ___ cfe-commits mailing list c

[PATCH] D70603: Change while to do-while

2020-06-25 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D70603#2114361 , @pi1024e wrote: > @MaskRay it's been months yet this hasn't landed yet. Why? It is usually assumed that the patch author pushes this commit. In this case, it seems that you don't have commit access. You'll ne

[PATCH] D70603: Change while to do-while

2020-06-25 Thread Seija Kijin via Phabricator via cfe-commits
pi1024e added a comment. @MaskRay it's been months yet this hasn't landed yet. Why? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70603/new/ https://reviews.llvm.org/D70603 ___ cfe-commits mailing list

[PATCH] D70603: Change while to do-while

2020-06-25 Thread Seija Kijin via Phabricator via cfe-commits
pi1024e added a comment. Any updates? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70603/new/ https://reviews.llvm.org/D70603 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D70603: Change while to do-while

2019-11-22 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added a comment. This is fine as NFC/NFCI patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70603/new/ https://reviews.llvm.org/D70603 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D70603: Change while to do-while

2019-11-22 Thread Seija Kijin via Phabricator via cfe-commits
pi1024e added a comment. What do you mean? I test compiled this and there are no errors after running the test benchmark. Was I supposed to do something else? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70603/new/ https://reviews.llvm.org/D70603

[PATCH] D70603: Change while to do-while

2019-11-22 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. Missing a test; please upload all patches with full context (`-U9`) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70603/new/ https://reviews.llvm.org/D70603 ___ cfe-comm

[PATCH] D70603: Change while to do-while

2019-11-22 Thread Seija Kijin via Phabricator via cfe-commits
pi1024e created this revision. pi1024e added a project: LLVM. Herald added a project: clang. Herald added a subscriber: cfe-commits. pi1024e added a reviewer: llvm.org. pi1024e edited reviewers, added: modocache, sammccall, Quuxplusone; removed: llvm.org. The assert statement says that the locati