[PATCH] D70723: [clangd] Store index::SymbolKind in HoverInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rG24439a761c5e: [clangd] Store index::SymbolKind in HoverInfo (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70723/new/ https://reviews

[PATCH] D70723: [clangd] Store index::SymbolKind in HoverInfo

merge_guards_bot added a comment. Build result: pass - 60506 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70723: [clangd] Store index::SymbolKind in HoverInfo

kadircet updated this revision to Diff 232519. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70723/new/ https://reviews.llvm.org/D70723 Files: clang-tools-ex

[PATCH] D70723: [clangd] Store index::SymbolKind in HoverInfo

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Hover.cpp:363 HI.Name = Macro.Name; - HI.Kind = indexSymbolKindToSymbolKind( - index::getSymbolInfoForMacro(*Macro.Inf

[PATCH] D70723: [clangd] Store index::SymbolKind in HoverInfo

merge_guards_bot added a comment. Build result: pass - 60291 tests passed, 0 failed and 732 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70723: [clangd] Store index::SymbolKind in HoverInfo

kadircet created this revision. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. LSP's SymbolKind has some shortcomings when it comes to C++ types, index::SymbolKind has more detailed info like Destructor, Parameter, MACRO