[PATCH] D70765: LTOVisibility.rst: fix up syntax in example

2020-01-08 Thread Teresa Johnson via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG43f938eddc8a: LTOVisibility.rst: fix up syntax in example (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70765/new/ https://reviews.

[PATCH] D70765: LTOVisibility.rst: fix up syntax in example

2020-01-08 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added a comment. In D70765#1807609 , @dankamongmen wrote: > > Typically the author commits the patch, unless they don't have commit > > access and request the reviewer to commit for them, but I don't see a > > request for that here. > > Thanks

[PATCH] D70765: LTOVisibility.rst: fix up syntax in example

2020-01-07 Thread Nick Black via Phabricator via cfe-commits
dankamongmen added a comment. > Typically the author commits the patch, unless they don't have commit access > and request the reviewer to commit for them, but I don't see a request for > that here. Thanks, Teresa. I indeed do not have commit access (so far as I know or can tell, anyway), so p

[PATCH] D70765: LTOVisibility.rst: fix up syntax in example

2020-01-06 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added a comment. In D70765#1802564 , @dankamongmen wrote: > I hate to bother anyone, but can this go ahead and get merged? :) thanks Typically the author commits the patch, unless they don't have commit access and request the reviewer to comm

[PATCH] D70765: LTOVisibility.rst: fix up syntax in example

2020-01-03 Thread Nick Black via Phabricator via cfe-commits
dankamongmen added a comment. I hate to bother anyone, but can this go ahead and get merged? :) thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70765/new/ https://reviews.llvm.org/D70765 ___ cfe-c

[PATCH] D70765: LTOVisibility.rst: fix up syntax in example

2019-12-05 Thread Nick Black via Phabricator via cfe-commits
dankamongmen added a comment. Thanks, @pcc! Is there anything I need to do, or am I just waiting on someone to merge this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70765/new/ https://reviews.llvm.org/D70765

[PATCH] D70765: LTOVisibility.rst: fix up syntax in example

2019-11-27 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70765/new/ https://reviews.llvm.org/D70765 ___ cfe-c

[PATCH] D70765: LTOVisibility.rst: fix up syntax in example

2019-11-26 Thread Nick Black via Phabricator via cfe-commits
dankamongmen created this revision. dankamongmen added a project: LLVM. Herald added subscribers: cfe-commits, dexonsmith, steven_wu, hiraditya, inglorion, mehdi_amini. Herald added a project: clang. dankamongmen added a reviewer: pcc. Pretty self-evident. This example was missing an lparen. Adde