[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

zahiraam added a comment. Added in the sycl_special_class attribute. This is still work in progress as I still have a few LIT tests failing and didn't address the issue of the separating sema from codegen work. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71016/new/ https://reviews.l

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

bader added a comment. In D71016#3063762 , @tschuett wrote: > Would a codegenSYCL directory help you to separate Sema from code generation? Moving wrapper kernel function generation to CodeGen library make sense to me. > Doesn't this make AST non-represe

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

lebedev.ri added a reviewer: rsmith. lebedev.ri added a comment. Doesn't this make AST non-representable of the reality, shouldn't the lowering happen in codegen, not in sema? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71016/new/ https://reviews

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

tschuett added a comment. In D71016#3063706 , @bader wrote: > In D71016#3063457 , @tschuett wrote: > >> It feels like you are doing codegen(OpenCL kernel) in Sema. Are OpenCL >> kernels the only approach. > > We ne

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

bader added a comment. In D71016#3063457 , @tschuett wrote: > It feels like you are doing codegen(OpenCL kernel) in Sema. Are OpenCL > kernels the only approach. We need to update the description of the patch to clarify that it applies to other GPU prog

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

tschuett added a comment. It feels like you are doing codegen(OpenCL kernel) in Sema. Are OpenCL kernels the only approach. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71016/new/ https://reviews.llvm.org/D71016 _

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

aaron.ballman added a comment. FWIW, it seems like precommit CI is failing with problems in `x64 windows > Clang.SemaSYCL::accessors-targets.cpp` (which is largely hidden by the spam from the CI pipeline, unfortunately). Also, you should address the tidy warnings. Comment at

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

bader added inline comments. Comment at: clang/lib/Sema/SemaSYCL.cpp:45 + /// accessor class. + static bool isSyclAccessorType(const QualType &Ty); + erichkeane wrote: > Isn't there a big rewrite going on downstream of these with > `sycl_special_class`? Why a

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaSYCL.cpp:45 + /// accessor class. + static bool isSyclAccessorType(const QualType &Ty); + Isn't there a big rewrite going on downstream of these with `sycl_special_class`? Why are we trying to u

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

ABataev added inline comments. Comment at: clang/include/clang/Sema/Sema.h:12798 + /// Access to SYCL kernels. + SmallVectorImpl &getSYCLKernels() { return SYCLKernels; } + `ArrayRef getSYCLKernels()` Comment at: clang/lib/Sema/SemaSYCL.cpp:9

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

bader commandeered this revision. bader edited reviewers, added: Fznamznon; removed: bader. bader added inline comments. Comment at: clang/test/CodeGenSYCL/device-functions.cpp:2 +// RUN: %clang_cc1 -triple spir64 -fsycl-is-device -S -emit-llvm %s -o - | FileCheck %s + +template

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

bader updated this revision to Diff 319909. bader added a comment. Addressed comment from Ronan in regression tests and synced them with the latest status. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71016/new/ https://reviews.llvm.org/D71016 F

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

bader updated this revision to Diff 319579. bader added a comment. Depends on D89909 Apply improvements developed in out-of-tree repository, which mostly are refactoring of SemaSYCL.cpp file. Rebase on ToT + D89909 (which only i

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

Fznamznon marked an inline comment as done. Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaSYCL.cpp:417 + Util::DeclContextDesc{clang::Decl::Kind::ClassTemplateSpecialization, +"accessor"}}; + return matchQualifiedTypeName(Ty, Sc

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

keryell added inline comments. Comment at: clang/lib/Sema/SemaSYCL.cpp:44 + +class KernelBodyTransform : public TreeTransform { +public: Feel free to add more comments in this area up to line 103. Comment at: clang/lib/Sema/SemaSYCL.cpp:417 +

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

Fznamznon updated this revision to Diff 233013. Fznamznon added a comment. Updated tests using address space attributes added by D71005 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71016/new/ https://reviews.llvm

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

Fznamznon created this revision. Herald added subscribers: cfe-commits, Anastasia, ebevhan, jfb, yaxunl, mgorny. Herald added a project: clang. Fznamznon added reviewers: bader, Naghasan, ABataev. All SYCL memory objects shared between host and device (buffers/images, these objects map to OpenCL b