[PATCH] D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

thakis added a comment. Breaks Win: http://45.33.8.238/win/3549/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71029/new/ https://reviews.llvm.org/D71029 ___ cfe-commits mailing list cfe-comm

[PATCH] D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

This revision was automatically updated to reflect the committed changes. Closed by commit rG99768b243cd7: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly… (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71029/new/ https://reviews.llvm.org/D71029 _

[PATCH] D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

sammccall added a comment. Thanks. Can someone approve the patch and I'll land it again :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71029/new/ https://reviews.llvm.org/D71029 ___ cfe-commits mail

[PATCH] D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

kbobyrev added a comment. In D71029#1769416 , @sammccall wrote: > @kbobyrev would you mind verifying this version of the patch also works? > I don't expect changes vs the last one: it's been restructured a lot but the > logic should be the same. I can

[PATCH] D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:65 + if (llvm::sys::fs::real_path(Path, Resolved)) +return Path; // On error; + return Resolved.str(); sammccall wrote: > j

[PATCH] D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

merge_guards_bot added a comment. Build result: pass - 60480 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

sammccall added a comment. Thanks for looking at this Jan, I should have put you on the reviewers in the first place... Comment at: clang-tools-extra/clangd/CompileCommands.cpp:53 + } + StringRef Path = Buf->get()->getBuffer().trim(); + if (Path.empty()) {

[PATCH] D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

sammccall updated this revision to Diff 232274. sammccall marked 5 inline comments as done. sammccall added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71029/new/ https://reviews.llvm.org/D71029 Files: clang-

[PATCH] D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

jkorous added a comment. The use of `xcrun` looks sound to me. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:53 + } + StringRef Path = Buf->get()->getBuffer().trim(); + if (Path.empty()) { The `trim()` is probably safe - just wondering if that cou

[PATCH] D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

merge_guards_bot added a comment. Build result: pass - 60480 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

merge_guards_bot added a comment. Build result: fail - 60479 tests passed, 1 failed and 726 were skipped. failed: libc++.std/thread/thread_mutex/thread_mutex_requirements/thread_mutex_requirements_mutex/thread_mutex_recursive/lock.pass.cpp Log files: console-log.txt

[PATCH] D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

sammccall updated this revision to Diff 232183. sammccall added a comment. Revert unneeded changes to tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71029/new/ https://reviews.llvm.org/D71029 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

sammccall added a comment. @kbobyrev would you mind verifying this version of the patch also works? I don't expect changes vs the last one: it's been restructured a lot but the logic should be the same. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

sammccall created this revision. sammccall added reviewers: kbobyrev, ilya-biryukov. sammccall added a project: clang. Herald added subscribers: ormris, mgorny. This was originally committed in 88bccded8fa169481fa367debf5ec615640635a1