[PATCH] D71037: [Diagnostic] Add ftabstop to -Wmisleading-indentation

Tyker added a comment. In D71037#1871089 , @efriedma wrote: > I just ran into this warning, and I think there's a bit of a discoverability > problem related to the width of tabs and -ftabstop. If you have mixed tabs > and spaces, and you've correctly sp

[PATCH] D71037: [Diagnostic] Add ftabstop to -Wmisleading-indentation

efriedma added a comment. I just ran into this warning, and I think there's a bit of a discoverability problem related to the width of tabs and -ftabstop. If you have mixed tabs and spaces, and you've correctly specified the tab stop width with -ftabstop, everything works fine. If you haven't

[PATCH] D71037: [Diagnostic] Add ftabstop to -Wmisleading-indentation

Tyker closed this revision. Tyker added a comment. In D71037#1803704 , @mstorsjo wrote: > In D71037#1803574 , @Tyker wrote: > > > In D71037#1803361 , @xbolva00 > > wrote: >

[PATCH] D71037: [Diagnostic] Add ftabstop to -Wmisleading-indentation

mstorsjo added a comment. In D71037#1803574 , @Tyker wrote: > In D71037#1803361 , @xbolva00 wrote: > > > Can you add a test case for that crash? Otherwise OK. > > > as i said. the bug can only occur for one line fil

[PATCH] D71037: [Diagnostic] Add ftabstop to -Wmisleading-indentation

xbolva00 added a comment. Ah, true. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71037/new/ https://reviews.llvm.org/D71037 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D71037: [Diagnostic] Add ftabstop to -Wmisleading-indentation

Tyker added a comment. In D71037#1803361 , @xbolva00 wrote: > Can you add a test case for that crash? Otherwise OK. as i said. the bug can only occur for one line files. so we can't have a run line and a the crashing line. so i wasn't able to make a tes

[PATCH] D71037: [Diagnostic] Add ftabstop to -Wmisleading-indentation

xbolva00 reopened this revision. xbolva00 added a comment. This revision is now accepted and ready to land. Can you add a test case for that crash? Otherwise OK. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71037/new/ https://reviews.llvm.org/D71037 _

[PATCH] D71037: [Diagnostic] Add ftabstop to -Wmisleading-indentation

Tyker updated this revision to Diff 236058. Tyker added a comment. This update should fixes the issue. the assert was incorrect. because file offsets are 0-based where as column numbers are 1-based. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71037/new/ https://reviews.llvm.org/D7103

[PATCH] D71037: [Diagnostic] Add ftabstop to -Wmisleading-indentation

mstorsjo added a comment. In D71037#1799792 , @mstorsjo wrote: > This broke my builds. I pushed a revert for this for now, to unbreak things. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71037/new/ https

[PATCH] D71037: [Diagnostic] Add ftabstop to -Wmisleading-indentation

mstorsjo added a comment. This broke my builds. A configure test that tries to compile `int main (void) { for( int i = 0; i < 9; i++ ); return 0; }` (a single line source file), with `-Wall` enabled, now triggers failed asserts: clang-10: ../tools/clang/lib/Parse/ParseStmt.cpp:1236: static un

[PATCH] D71037: [Diagnostic] Add ftabstop to -Wmisleading-indentation

This revision was automatically updated to reflect the committed changes. Closed by commit rGb47b35ff51b3: [Diagnostic] Add ftabstop to -Wmisleading-indentation (authored by Tyker). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANG