[PATCH] D71090: [clangd] Navigation from definition of template specialization to primary template

2019-12-07 Thread Nathan Ridge via Phabricator via cfe-commits
nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:240 +// it's more useful to navigate to the template declaration. +if (Preferred->getLocation() == IdentStartLoc) { + if (auto *CTSD =

[PATCH] D71090: [clangd] Navigation from definition of template specialization to primary template

2019-12-07 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:240 +// it's more useful to navigate to the template declaration. +if (Preferred->getLocation() == IdentStartLoc) { + if (auto *CTSD = dyn_cast(Preferred)) { sammccall

[PATCH] D71090: [clangd] Navigation from definition of template specialization to primary template

2019-12-07 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 232725. nridge marked 2 inline comments as done. nridge retitled this revision from "[clangd] Navigation from definition of template specialization to primary template Fixes https://github.com/clangd/clangd/issues/212.; to "[clangd] Navigation from

[PATCH] D71090: [clangd] Navigation from definition of template specialization to primary template

2019-12-07 Thread Nathan Ridge via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe8716a6df7ab: [clangd] Navigation from definition of template specialization to primary… (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION