[PATCH] D71092: [VFS] Use path canonicalization on all paths

2019-12-05 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. I would add, take a look at the existing unit tests (llvm/unittests/Support/VirtualFileSystemTests.cpp) and audit for _WIN32 ifdefs that we can remove after this change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71092/new/ https://reviews.llvm.org/D71092 __

[PATCH] D71092: [VFS] Use path canonicalization on all paths

2019-12-05 Thread Adrian McCarthy via Phabricator via cfe-commits
amccarth planned changes to this revision. amccarth added a comment. Hold off on this one. It needs an explicit test for canonicalization. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71092/new/ https://reviews.llvm.org/D71092 ___ cfe-com

[PATCH] D71092: [VFS] Use path canonicalization on all paths

2019-12-05 Thread Adrian McCarthy via Phabricator via cfe-commits
amccarth created this revision. amccarth added reviewers: rnk, vsapsai, arphaman. Herald added subscribers: llvm-commits, dexonsmith, hiraditya. Herald added a project: LLVM. The virtual file system had an option to eliminate dots from paths (e.g., `/foo/./bar` -> `/foo/bar`). Because of differe