[PATCH] D71141: [Wdocumentation] Use C2x/C++14 deprecated attribute

2019-12-10 Thread Mark de Wever via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Mordante marked 2 inline comments as done. Closed by commit rGb6d386f6f996: [Wdocumentation] Use C2x/C++14 deprecated attribute (authored by Mordante). Changed prior to commit:

[PATCH] D71141: [Wdocumentation] Use C2x/C++14 deprecated attribute

2019-12-09 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 marked an inline comment as done. gribozavr2 added inline comments. Comment at: clang/test/Sema/warn-documentation-fixits.c:27 + +// CHECK: fix-it:"{{.*}}":{7:1-7:1}:"[[ATTRIBUTE]] " +// CHECK: fix-it:"{{.*}}":{11:1-11:1}:"[[ATTRIBUTE]] " Mordante

[PATCH] D71141: [Wdocumentation] Use C2x/C++14 deprecated attribute

2019-12-09 Thread Mark de Wever via Phabricator via cfe-commits
Mordante marked 5 inline comments as done. Mordante added a comment. Thanks for your review of this set of patches! Comment at: clang/lib/AST/CommentSema.cpp:698 + // - In C2x/C++14 we prefer [[deprecated]] + // - If not found or an older C/C++ look for

[PATCH] D71141: [Wdocumentation] Use C2x/C++14 deprecated attribute

2019-12-09 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 accepted this revision. gribozavr2 added a comment. LGTM with comments fixed. Comment at: clang/lib/AST/CommentSema.cpp:698 + // - In C2x/C++14 we prefer [[deprecated]] + // - If not found or an older C/C++ look for __attribute__((deprecated)) +

[PATCH] D71141: [Wdocumentation] Use C2x/C++14 deprecated attribute

2019-12-08 Thread Mark de Wever via Phabricator via cfe-commits
Mordante marked an inline comment as done. Mordante added a comment. Thanks for the review! I'll wait with committing until @gribozavr2 had time to review this patch and D71140 . Comment at: clang/lib/AST/CommentSema.cpp:693 +StringRef

[PATCH] D71141: [Wdocumentation] Use C2x/C++14 deprecated attribute

2019-12-07 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/AST/CommentSema.cpp:693 +StringRef AttributeSpelling = +CPlusPlus14 ? "[[deprecated]]" : "__attribute__((deprecated))";

[PATCH] D71141: [Wdocumentation] Use C2x/C++14 deprecated attribute

2019-12-07 Thread Mark de Wever via Phabricator via cfe-commits
Mordante updated this revision to Diff 232695. Mordante retitled this revision from "[Wdocumentation] Use C++14 deprecated attribute" to "[Wdocumentation] Use C2x/C++14 deprecated attribute". Mordante edited the summary of this revision. Mordante added a comment. Added C2x support as requested.