[PATCH] D71189: [Parser] Don't crash on MS assembly if target desc/asm parser isn't linked in.

This revision was automatically updated to reflect the committed changes. Closed by commit rG94603ec11b55: [Parser] Don't crash on MS assembly if target desc/asm parser isn't linked in. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D71189: [Parser] Don't crash on MS assembly if target desc/asm parser isn't linked in.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71189/new/ https://reviews.llvm.org/D71189 __

[PATCH] D71189: [Parser] Don't crash on MS assembly if target desc/asm parser isn't linked in.

merge_guards_bot added a comment. Build result: pass - 60607 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71189: [Parser] Don't crash on MS assembly if target desc/asm parser isn't linked in.

sammccall updated this revision to Diff 232798. sammccall marked an inline comment as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71189/new/ https://reviews.llvm.org/D71189 Files: clang-tools-e

[PATCH] D71189: [Parser] Don't crash on MS assembly if target desc/asm parser isn't linked in.

sammccall marked 4 inline comments as done. sammccall added inline comments. Comment at: clang/lib/Parse/ParseStmtAsm.cpp:591 std::unique_ptr MAI( TheTarget->createMCAsmInfo(*MRI, TT, MCOptions)); // Get the instruction descriptor. kadircet wrote: >

[PATCH] D71189: [Parser] Don't crash on MS assembly if target desc/asm parser isn't linked in.

merge_guards_bot added a comment. Build result: pass - 60607 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71189: [Parser] Don't crash on MS assembly if target desc/asm parser isn't linked in.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, ilya-biryukov, mgorny. Herald added a project: clang. sammccall updated this revision to Diff 232791. sammccall added a comment. revert random meaningless ch

[PATCH] D71189: [Parser] Don't crash on MS assembly if target desc/asm parser isn't linked in.

sammccall updated this revision to Diff 232791. sammccall added a comment. revert random meaningless changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71189/new/ https://reviews.llvm.org/D71189 Files: clang-tools-extra/clangd/Diagnostics.cpp

[PATCH] D71189: [Parser] Don't crash on MS assembly if target desc/asm parser isn't linked in.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:1018 + } // namespace nit: empty line Comment at: clang/lib/Parse/ParseStmtAsm.cpp:591 std::unique_ptr MAI( TheTarget->createMCAsmI

[PATCH] D71189: [Parser] Don't crash on MS assembly if target desc/asm parser isn't linked in.

merge_guards_bot added a comment. Build result: pass - 60607 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt