[PATCH] D71221: [HIP] Add option --gpu-max-threads-per-block=n

2020-01-07 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9f2d8b5c0cdb: [HIP] Add option --gpu-max-threads-per-block=n (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71221: [HIP] Add option --gpu-max-threads-per-block=n

2020-01-05 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71221/new/ https://reviews.llvm.org/D71221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D71221: [HIP] Add option --gpu-max-threads-per-block=n

2019-12-21 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 235025. yaxunl added a comment. revised by Artem's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71221/new/ https://reviews.llvm.org/D71221 Files: clang/include/clang/Basic/LangOptions.def clang/include/clang/Driver/Options.td

[PATCH] D71221: [HIP] Add option --gpu-max-threads-per-block=n

2019-12-20 Thread Artem Belevich via Phabricator via cfe-commits
tra added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:8067 +unsigned MaxThreadsPerBlock = +IsHIPKernel ? M.getLangOpts().GPUMaxThreadsPerBlock : 256; +std::string AttrVal = std::string("1,") + llvm::utostr(MaxThreadsPerBlock);

[PATCH] D71221: [HIP] Add option --gpu-max-threads-per-block=n

2019-12-20 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl marked 2 inline comments as done. yaxunl added a comment. In D71221#1791802 , @tra wrote: > What's the use case for this flag? If a kernel is launched with a block size greater than the default max block size, explicit launch bound is required.

[PATCH] D71221: [HIP] Add option --gpu-max-threads-per-block=n

2019-12-19 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. What's the use case for this flag? Comment at: clang/lib/CodeGen/TargetInfo.cpp:8067 +unsigned MaxThreadsPerBlock = +IsHIPKernel ? M.getLangOpts().GPUMaxThreadsPerBlock : 256; +std::string AttrVal = std::string("1,") +

[PATCH] D71221: [HIP] Add option --gpu-max-threads-per-block=n

2019-12-19 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71221/new/ https://reviews.llvm.org/D71221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D71221: [HIP] Add option --gpu-max-threads-per-block=n

2019-12-09 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: nhaehnle, jvesely. Add this option to change the default launch bounds. https://reviews.llvm.org/D71221 Files: clang/include/clang/Basic/LangOptions.def clang/include/clang/Driver/Options.td