[PATCH] D71286: [SYCL] Add support for auxiliary triple specification to Frontend

2019-12-11 Thread Alexey Bader via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGcb30ad728f0b: [SYCL] Add support for auxiliary triple specification to Frontend (authored by bader). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71286/new/

[PATCH] D71286: [SYCL] Add support for auxiliary triple specification to Frontend

2019-12-11 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. Build result: pass - 60675 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71286: [SYCL] Add support for auxiliary triple specification to Frontend

2019-12-11 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71286/new/ https://reviews.llvm.org/D71286 ___

[PATCH] D71286: [SYCL] Add support for auxiliary triple specification to Frontend

2019-12-11 Thread Alexey Bader via Phabricator via cfe-commits
bader updated this revision to Diff 233303. bader added a comment. Added LIT test. If it's okay, I'll add similar test for OpenMP device compiler to clang/test/OpenMP directory. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71286/new/ https://rev

[PATCH] D71286: [SYCL] Add support for auxiliary triple specification to Frontend

2019-12-10 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In D71286#1777917 , @bader wrote: > In D71286#1777894 , @ABataev wrote: > > > Most probably, just missed the testing of the frontend part here > > > Should I add test for both: SYCL and Open

[PATCH] D71286: [SYCL] Add support for auxiliary triple specification to Frontend

2019-12-10 Thread Alexey Bader via Phabricator via cfe-commits
bader added a comment. In D71286#1777894 , @ABataev wrote: > Most probably, just missed the testing of the frontend part here Should I add test for both: SYCL and OpenMP? What is the right place for this kind of tests: clang/test/Preprocessor/ or clang/

[PATCH] D71286: [SYCL] Add support for auxiliary triple specification to Frontend

2019-12-10 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. Build result: pass - 60674 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71286: [SYCL] Add support for auxiliary triple specification to Frontend

2019-12-10 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. Most probably, just missed the testing of the frontend part here Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71286/new/ https://reviews.llvm.org/D71286 ___ cfe-commits mailin

[PATCH] D71286: [SYCL] Add support for auxiliary triple specification to Frontend

2019-12-10 Thread Alexey Bader via Phabricator via cfe-commits
bader created this revision. bader added a reviewer: ABataev. Herald added subscribers: cfe-commits, Anastasia, ebevhan. Herald added a reviewer: jdoerfert. Herald added a project: clang. bader added a comment. I'm looking for test suggestions as I was not able to find tests covering similar chan

[PATCH] D71286: [SYCL] Add support for auxiliary triple specification to Frontend

2019-12-10 Thread Alexey Bader via Phabricator via cfe-commits
bader added a comment. I'm looking for test suggestions as I was not able to find tests covering similar changes for OpenMP compiler. https://github.com/llvm/llvm-project/commit/59d7b77b16bf11810091fe75a4348198783d3fbc modifies driver and front-end, but adds only driver tests. Repository: r