[PATCH] D71300: [clangd] Deduplicate refs from index for cross-file rename.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0004aad5565: [clangd] Deduplicate refs from index for cross-file rename. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71300/new/ htt

[PATCH] D71300: [clangd] Deduplicate refs from index for cross-file rename.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71300/new/ https://reviews.llvm.org/D71300

[PATCH] D71300: [clangd] Deduplicate refs from index for cross-file rename.

merge_guards_bot added a comment. Build result: pass - 60688 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71300: [clangd] Deduplicate refs from index for cross-file rename.

hokein added a comment. thanks for the fast review. Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:34 +// Covnert a Range to a Ref. +std::pair toRef(const clangd::Range &Range, + llvm::StringRef Path) { --

[PATCH] D71300: [clangd] Deduplicate refs from index for cross-file rename.

hokein updated this revision to Diff 233262. hokein marked an inline comment as done. hokein added a comment. address review comment -- simplify the unittest code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71300/new/ https://reviews.llvm.org/D7

[PATCH] D71300: [clangd] Deduplicate refs from index for cross-file rename.

ilya-biryukov added a comment. The fix itself LGTM. Just a few NITs and this is good to go. Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:34 +// Covnert a Range to a Ref. +std::pair toRef(const clangd::Range &Range, +

[PATCH] D71300: [clangd] Deduplicate refs from index for cross-file rename.

merge_guards_bot added a comment. Build result: pass - 60688 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71300: [clangd] Deduplicate refs from index for cross-file rename.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman, mgrang, jkorous, MaskRay. Herald added a project: clang. If the index returns duplicated refs, it will trigger the assertion in BuildRenameEdit (we expect the processing