[PATCH] D71408: [lit] Remove lit's REQUIRES-ANY directive

2019-12-17 Thread Thomas Preud'homme via Phabricator via cfe-commits
thopre added a subscriber: nemanjai. thopre added a comment. Herald added a subscriber: wuzish. In D71408#1787959 , @jdenny wrote: > This breaks the lit test suite. `llvm/utils/lit/tests/shtest-format.py` > needs to be updated for the removed tests.

[PATCH] D71408: [lit] Remove lit's REQUIRES-ANY directive

2019-12-17 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added a comment. In D71408#1788582 , @thopre wrote: > This is embarrassing. It happens. > I presume ninja check-all includes those 2 tests so I'm not sure how I missed > it. It should. > On a related note, I used to receive mail notification

[PATCH] D71408: [lit] Remove lit's REQUIRES-ANY directive

2019-12-17 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added a comment. This breaks the lit test suite. `llvm/utils/lit/tests/shtest-format.py` needs to be updated for the removed tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71408/new/ https://reviews.llvm.org/D71408

[PATCH] D71408: [lit] Remove lit's REQUIRES-ANY directive

2019-12-17 Thread Ulrich Weigand via Phabricator via cfe-commits
uweigand added a comment. It looks like this caused build bot failures: http://lab.llvm.org:8011/builders/clang-s390x-linux/builds/28928/steps/ninja%20check%201/logs/FAIL%3A%20lit%3A%3A%20shtest-format.py

[PATCH] D71408: [lit] Remove lit's REQUIRES-ANY directive

2019-12-17 Thread Thomas Preud'homme via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGddd0bb8dba2a: [lit] Remove lits REQUIRES-ANY directive (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71408/new/

[PATCH] D71408: [lit] Remove lit's REQUIRES-ANY directive

2019-12-16 Thread Greg Parker via Phabricator via cfe-commits
gparker42 accepted this revision. gparker42 added a comment. This revision is now accepted and ready to land. Good. `REQUIRES-ANY` was preserved when the boolean expressions were added because libc++ was still using it. libc++ has since changed their tests so removing it should be fine now.

[PATCH] D71408: [lit] Remove lit's REQUIRES-ANY directive

2019-12-12 Thread Evgenii Stepanov via Phabricator via cfe-commits
eugenis added a comment. Nice cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71408/new/ https://reviews.llvm.org/D71408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71408: [lit] Remove lit's REQUIRES-ANY directive

2019-12-12 Thread Thomas Preud'homme via Phabricator via cfe-commits
thopre updated this revision to Diff 233712. thopre added a comment. Herald added subscribers: Sanitizers, cfe-commits, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, delcypher, niosHD,