[PATCH] D71556: [AArch64][SVE] Implement intrinsic for non-faulting loads

kmclaughlin planned changes to this revision. kmclaughlin added a comment. Thanks for the feedback on this patch, @efriedma & @sdesmalen! I think there is still value in adding a NonFaulting flag to MachineMemOperand so that we can benefit from legalisation, but as this is not a requirement for

[PATCH] D71556: [AArch64][SVE] Implement intrinsic for non-faulting loads

efriedma added a comment. > Perhaps we can clarify the intent that the non-faulting mode may have > side-effects by renaming the flag to something like > NonFaultingWithSideEffects? We could specify something like that... but that probably requires some changes to target-independent

[PATCH] D71556: [AArch64][SVE] Implement intrinsic for non-faulting loads

sdesmalen added a comment. In D71556#1786465 , @efriedma wrote: > I'm not sure it's legal to transform a non-faulting load to a load with a > non-faulting flag? At least, we'd need to consider the implications of that > very carefully. In particular,

[PATCH] D71556: [AArch64][SVE] Implement intrinsic for non-faulting loads

sdesmalen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:329 + +def non_faulting_load : + PatFrag<(ops node:$ptr, node:$pred, node:$def), This duplicates a lot of code, maybe it makes sense to combine this into a multiclass.

[PATCH] D71556: [AArch64][SVE] Implement intrinsic for non-faulting loads

efriedma added a comment. I'm not sure it's legal to transform a non-faulting load to a load with a non-faulting flag? At least, we'd need to consider the implications of that very carefully. In particular, I'm concerned about the interaction with intrinsics that read/write FFR. I mean, you

[PATCH] D71556: [AArch64][SVE] Implement intrinsic for non-faulting loads

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, paulwalker-arm, efriedma, dancgr, mgudim. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. Adds the llvm.aarch64.sve.ldnf1