[PATCH] D71666: [clang-tidy] Fix readability-const-return-type identifying the wrong `const` token

aaron.ballman closed this revision. aaron.ballman added a comment. In D71666#1795068 , @ilya wrote: > @aaron.ballman, thanks for reviewing. Do you mind submitting this, as I don't > have commit access? Happy to do so, thank you for the fix! I've commit

[PATCH] D71666: [clang-tidy] Fix readability-const-return-type identifying the wrong `const` token

ilya updated this revision to Diff 235157. ilya marked an inline comment as done. ilya added a comment. Doxygen format the documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71666/new/ https://reviews.llvm.org/D71666 Files:

[PATCH] D71666: [clang-tidy] Fix readability-const-return-type identifying the wrong `const` token

ilya marked 2 inline comments as done. ilya added a comment. @aaron.ballman, thanks for reviewing. Do you mind submitting this, as I don't have commit access? Comment at: clang-tools-extra/clang-tidy/utils/LexerUtils.h:95-97 +/// Assuming that ``Range`` spans a CVR-qualified

[PATCH] D71666: [clang-tidy] Fix readability-const-return-type identifying the wrong `const` token

ilya updated this revision to Diff 235156. ilya added a comment. Update LexerUtils.h documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71666/new/ https://reviews.llvm.org/D71666 Files:

[PATCH] D71666: [clang-tidy] Fix readability-const-return-type identifying the wrong `const` token

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a commenting request. Comment at: clang-tools-extra/clang-tidy/utils/LexerUtils.h:95-97 +/// Assuming that ``Range`` spans a CVR-qualified type,

[PATCH] D71666: [clang-tidy] Fix readability-const-return-type identifying the wrong `const` token

ilya updated this revision to Diff 234560. ilya added a comment. Fix documentation in LexerUtils.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71666/new/ https://reviews.llvm.org/D71666 Files:

[PATCH] D71666: [clang-tidy] Fix readability-const-return-type identifying the wrong `const` token

ilya created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Replace tidy::utils::lexer::getConstQualifyingToken with a corrected and also generalized to other qualifiers variant - getQualifyingToken. Fixes: http://llvm.org/PR44326 Repository: