[PATCH] D71677: [ms] [X86] Use "P" modifier on operands to call instructions in inline X86 assembly.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc5b614fa9a1: [ms] [X86] Use "P" modifier on operands to call instructions in inline X86… (authored by epastor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D71677: [ms] [X86] Use "P" modifier on operands to call instructions in inline X86 assembly.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61087 tests passed, 0 failed and 728 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D71677: [ms] [X86] Use "P" modifier on operands to call instructions in inline X86 assembly.

epastor updated this revision to Diff 235035. epastor marked an inline comment as done. epastor added a comment. Fix test; missing anchor meant the previous version would not catch a regression. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71677/n

[PATCH] D71677: [ms] [X86] Use "P" modifier on operands to call instructions in inline X86 assembly.

epastor marked 2 inline comments as done. epastor added inline comments. Comment at: llvm/test/CodeGen/X86/ms-inline-asm-PR44272.ll:15 +; CHECK: {{## InlineAsm Start|#APP}} +; CHECK: call{{l|q}} func +; CHECK: {{## InlineAsm End|#NO_APP}} rnk wrote: > I'd suggest

[PATCH] D71677: [ms] [X86] Use "P" modifier on operands to call instructions in inline X86 assembly.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:2871 + // differently when referenced in MS-style inline assembly. + if (Name.startswith("call") || Name.startswit

[PATCH] D71677: [ms] [X86] Use "P" modifier on operands to call instructions in inline X86 assembly.

epastor added a comment. In D71677#1790458 , @rnk wrote: > Where is {0:P} actually documented? I don't see it in LangRef, but I do see > it in the code. https://llvm.org/docs/LangRef.html#asm-template-argument-modifiers, under X86; specifically documen

[PATCH] D71677: [ms] [X86] Use "P" modifier on operands to call instructions in inline X86 assembly.

rnk added a comment. Where is {0:P} actually documented? I don't see it in LangRef, but I do see it in the code. Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:2871 + // differently when referenced in MS-style inline assembly. + if (Name.startswith("call") || Nam

[PATCH] D71677: [ms] [X86] Use "P" modifier on operands to call instructions in inline X86 assembly.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60853 tests passed, 0 failed and 726 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings