This revision was automatically updated to reflect the committed changes.
Closed by commit rGd18fbfc09720: Relax the rules around objc_alloc and
objc_alloc_init optimizations. (authored by MadCoder).
Changed prior to commit:
https://reviews.llvm.org/D71682?vs=234644&id=238161#toc
Repository:
ahatanak accepted this revision.
ahatanak added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71682/new/
https://reviews.llvm.org/D71682
___
ahatanak added inline comments.
Comment at: clang/test/CodeGenObjC/objc-alloc-init.m:30
@implementation Y
++(Class)class {
MadCoder wrote:
> ahatanak wrote:
> > Can you add a test case for `[[self class] alloc]` to test the code in
> > `tryGenerateSpecialized
MadCoder marked an inline comment as done.
MadCoder added inline comments.
Comment at: clang/test/CodeGenObjC/objc-alloc-init.m:30
@implementation Y
++(Class)class {
ahatanak wrote:
> Can you add a test case for `[[self class] alloc]` to test the code in
> `t
ahatanak added inline comments.
Comment at: clang/test/CodeGenObjC/objc-alloc-init.m:30
@implementation Y
++(Class)class {
Can you add a test case for `[[self class] alloc]` to test the code in
`tryGenerateSpecializedMessageSend`?
Repository:
rG LLVM Gith
MadCoder created this revision.
MadCoder added reviewers: rjmccall, arphaman, erik.pilkington, ahatanak.
MadCoder added a project: clang.
Herald added subscribers: cfe-commits, dexonsmith.
MadCoder edited the summary of this revision.
Today the optimization is limited to:
- `[ClassName alloc]`
-
