This revision was automatically updated to reflect the committed changes.
Closed by commit rG42f9d0c0bee3: [objc_direct] Tigthen checks for direct
methods (authored by MadCoder).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71694/new/
teemperor added inline comments.
Comment at: clang/test/CodeGenObjC/direct-method.m:196
+@implementation Foo (Cat)
+// CHECK-LABEL: define hidden i32 @"\01-[Foo(Cat) directMethodInCategory]"(
+- (int)directMethodInCategory {
MadCoder wrote:
> aprantl wrote:
> >
MadCoder updated this revision to Diff 234810.
MadCoder added a comment.
Removed the category from the direct method name mangling as discussed with
@aprantl
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71694/new/
https://reviews.llvm.org/D71694
Files:
MadCoder marked an inline comment as done.
MadCoder added inline comments.
Comment at: clang/test/CodeGenObjC/direct-method.m:196
+@implementation Foo (Cat)
+// CHECK-LABEL: define hidden i32 @"\01-[Foo(Cat) directMethodInCategory]"(
+- (int)directMethodInCategory {
aprantl added a subscriber: teemperor.
aprantl added inline comments.
Comment at: clang/test/CodeGenObjC/direct-method.m:196
+@implementation Foo (Cat)
+// CHECK-LABEL: define hidden i32 @"\01-[Foo(Cat) directMethodInCategory]"(
+- (int)directMethodInCategory {
MadCoder updated this revision to Diff 234778.
MadCoder added a comment.
I had forgotten to clang format and left some tabs here... some day I'll fix my
vim config
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71694/new/
https://reviews.llvm.org/D71694
Files:
MadCoder updated this revision to Diff 234777.
MadCoder added a comment.
Addressed @aprantl review feedback.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71694/new/
https://reviews.llvm.org/D71694
Files:
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/lib/AST/DeclObjC.cpp
MadCoder marked an inline comment as done.
MadCoder added inline comments.
Comment at: clang/lib/AST/DeclObjC.cpp:963
if (ObjCInterfaceDecl *IFD = ImplD->getClassInterface()) {
- if (ObjCMethodDecl *MD = IFD->getMethod(getSelector(),
-
aprantl added inline comments.
Comment at: clang/lib/AST/DeclObjC.cpp:963
if (ObjCInterfaceDecl *IFD = ImplD->getClassInterface()) {
- if (ObjCMethodDecl *MD = IFD->getMethod(getSelector(),
- isInstanceMethod()))
+ //
aprantl added a comment.
Added superficial LLVM coding style comments.
Comment at: clang/lib/Sema/SemaDeclObjC.cpp:4735
+// Merge directness from the canonical declaration upfront
+if (!ObjCMethod->isDirectMethod()) {
missing `.` at end of sentence.
MadCoder added a subscriber: aprantl.
MadCoder added inline comments.
Comment at: clang/test/CodeGenObjC/direct-method.m:196
+@implementation Foo (Cat)
+// CHECK-LABEL: define hidden i32 @"\01-[Foo(Cat) directMethodInCategory]"(
+- (int)directMethodInCategory {
MadCoder updated this revision to Diff 234684.
MadCoder added a comment.
Small update because I uploaded before the full completion of the test-suite
and somehow it's sentient and punished me... (some diagnostics were too verbose
and stuttering things with `Sema::CheckObjCMethodOverrides`).
MadCoder created this revision.
MadCoder added reviewers: rjmccall, dexonsmith, erik.pilkington, ahatanak,
arphaman.
MadCoder added a project: clang.
Herald added a subscriber: cfe-commits.
Because the name of a direct method must be agreed upon by the caller and the
implementation, certain bad
13 matches
Mail list logo
