[PATCH] D71709: Give frontend dump flags consistent names (*-dump instead of dump-*)

herzka updated this revision to Diff 235188. herzka added a comment. rebase, restore changes to CC1Options.td that I left out of last revision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71709/new/ https://reviews.llvm.org/D71709 Files:

[PATCH] D71709: Give frontend dump flags consistent names (*-dump instead of dump-*)

modocache added a subscriber: mehdi_amini. modocache added a comment. Ah, I'm sorry I wasn't clear -- instead of changing a lot of tests to use the new names exclusively, my suggestion was to change one or two tests to use the new canonical name, and have the remaining tests keep using the

[PATCH] D71709: Give frontend dump flags consistent names (*-dump instead of dump-*)

herzka updated this revision to Diff 234966. herzka added a comment. Herald added a reviewer: jdoerfert. change flags in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71709/new/ https://reviews.llvm.org/D71709 Files:

[PATCH] D71709: Give frontend dump flags consistent names (*-dump instead of dump-*)

herzka added a comment. I worry that repeating all those names in those tests might be noisy. I think I'll switch those to use the new name, but add another test that makes sure both names still work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71709: Give frontend dump flags consistent names (*-dump instead of dump-*)

modocache requested changes to this revision. modocache added subscribers: jroelofs, echristo. modocache added a comment. This revision now requires changes to proceed. Grepping for "dump-tokens", I can see one regression test that exercises this option: clang/test/Lexer/dollar-idents.c.

[PATCH] D71709: Give frontend dump flags consistent names (*-dump instead of dump-*)

herzka updated this revision to Diff 234746. herzka added a comment. Update argument parsing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71709/new/ https://reviews.llvm.org/D71709 Files: clang/include/clang/Driver/CC1Options.td

[PATCH] D71709: Give frontend dump flags consistent names (*-dump instead of dump-*)

herzka added a comment. @modocache, should I add a unit test for these aliases or would that be too trivial? I don't see unit tests for all the existing flags. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71709/new/

[PATCH] D71709: Give frontend dump flags consistent names (*-dump instead of dump-*)

herzka created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. herzka added a reviewer: modocache. herzka added a comment. @modocache, should I add a unit test for these aliases or would that be too trivial? I don't see unit tests for all the existing flags.