[PATCH] D71823: Support Swift calling convention for WebAssembly targets

This revision was automatically updated to reflect the committed changes. Closed by commit rGc5bd3d07262f: Support Swift calling convention for WebAssembly targets (authored by kateinoigakukun, committed by dschuff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D71823: Support Swift calling convention for WebAssembly targets

kateinoigakukun added a comment. Could you merge this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71823/new/ https://reviews.llvm.org/D71823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D71823: Support Swift calling convention for WebAssembly targets

kateinoigakukun added a comment. In D71823#1834488 , @dschuff wrote: > Sorry we left this dangling for so long. This little change looks fine; I > guess you must be in the process of porting swift to wasm? Do you have any > more detailed plans for that w

[PATCH] D71823: Support Swift calling convention for WebAssembly targets

dschuff accepted this revision. dschuff added a comment. This revision is now accepted and ready to land. Sorry we left this dangling for so long. This little change looks fine; I guess you must be in the process of porting swift to wasm? Do you have any more detailed plans for that written down

[PATCH] D71823: Support Swift calling convention for WebAssembly targets

kateinoigakukun marked an inline comment as done. kateinoigakukun added inline comments. Comment at: clang/lib/Basic/Targets/WebAssembly.h:122 +case CC_Swift: + return CCCR_OK; +default: sbc100 wrote: > This seems to disagree with the longer list in

[PATCH] D71823: Support Swift calling convention for WebAssembly targets

sbc100 added inline comments. Comment at: clang/lib/Basic/Targets/WebAssembly.h:122 +case CC_Swift: + return CCCR_OK; +default: This seems to disagree with the longer list in `callingConvSupported`.Is this going to generate unnecessary warnings?

[PATCH] D71823: Support Swift calling convention for WebAssembly targets

kateinoigakukun updated this revision to Diff 235085. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71823/new/ https://reviews.llvm.org/D71823 Files: clang/lib/Basic/

[PATCH] D71823: Support Swift calling convention for WebAssembly targets

kateinoigakukun created this revision. Herald added subscribers: cfe-commits, sunfish, aheejin, jgravelle-google, sbc100, dschuff. Herald added a project: clang. Support Swift calling convention for WebAssembly targets This adds basic support for the Swift calling convention with WebAssembly ta