[PATCH] D72014: [PowerPC]: Add powerpcspe target triple subarch component

jhibbits added a comment. Any more feedback on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72014/new/ https://reviews.llvm.org/D72014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D72014: [PowerPC]: Add powerpcspe target triple subarch component

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72014/new/ https://reviews.llvm.org/D72014 ___ cfe-

[PATCH] D72014: [PowerPC]: Add powerpcspe target triple subarch component

This revision was automatically updated to reflect the committed changes. Closed by commit rGff0311c4b3b9: [PowerPC]: Add powerpcspe target triple subarch component (authored by chmeee). Changed prior to commit: https://reviews.llvm.org/D72014?vs=235716&id=236937#toc Repository: rG LLVM Gith

[PATCH] D72014: [PowerPC]: Add powerpcspe target triple subarch component

jhibbits created this revision. jhibbits added a reviewer: PowerPC. Herald added subscribers: llvm-commits, cfe-commits, steven.zhang, shchenz, jsji, dexonsmith, kbarton, hiraditya, krytarowski, arichardson, nemanjai, emaste. Herald added projects: clang, LLVM. This allows the use of '-target po

[PATCH] D72014: [PowerPC]: Add powerpcspe target triple subarch component

jhibbits updated this revision to Diff 235637. jhibbits added a comment. Fix a test typo made at the last minute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72014/new/ https://reviews.llvm.org/D72014 Files: clang/lib/Basic/Targets/PPC.cpp c

[PATCH] D72014: [PowerPC]: Add powerpcspe target triple subarch component

arichardson added inline comments. Comment at: clang/test/Preprocessor/init.c:7628 +// PPC32-SPE-TGT:#define __SPE__ 1 // // RUN: %clang_cc1 -E -dM -ffreestanding -triple=powerpc-unknown-linux-gnu -target-cpu 8548 < /dev/null | FileCheck -match-full-lines -check-prefix PPC85

[PATCH] D72014: [PowerPC]: Add powerpcspe target triple subarch component

jhibbits marked an inline comment as done. jhibbits added inline comments. Comment at: clang/test/Preprocessor/init.c:7628 +// PPC32-SPE-TGT:#define __SPE__ 1 // // RUN: %clang_cc1 -E -dM -ffreestanding -triple=powerpc-unknown-linux-gnu -target-cpu 8548 < /dev/null | FileChec

[PATCH] D72014: [PowerPC]: Add powerpcspe target triple subarch component

jhibbits updated this revision to Diff 235668. jhibbits added a comment. Reuse the SPE feature test preprocessor test check instead of duplicating it. powerpcspe-* is exactly equivalent to the -mspe command line argument. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D72014: [PowerPC]: Add powerpcspe target triple subarch component

Jim added a comment. Could you add tests in llvm/unittests/ADT/TripleTest.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72014/new/ https://reviews.llvm.org/D72014 ___ cfe-commits mailing list cfe-c

[PATCH] D72014: [PowerPC]: Add powerpcspe target triple subarch component

jhibbits updated this revision to Diff 235716. jhibbits added a comment. Add triple unit test. I chose freebsd as the OS since that's my environment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72014/new/ https://reviews.llvm.org/D72014 Files: