[PATCH] D72035: [analyzer][NFC] Use CallEvent checker callback in GenericTaintChecker

steakhal marked 2 inline comments as done. steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:113 const CheckerContext &C) { - const FunctionDecl *FDecl = C.getCalleeDecl(CE); +

[PATCH] D72035: [analyzer][NFC] Use CallEvent checker callback in GenericTaintChecker

NoQ added inline comments. Herald added a subscriber: ASDenysPetrov. Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:113 const CheckerContext &C) { - const FunctionDecl *FDecl = C.getCalleeDecl(CE); + asser

[PATCH] D72035: [analyzer][NFC] Use CallEvent checker callback in GenericTaintChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rG95a94df5a9c3: [analyzer][NFC] Use CallEvent checker callback in GenericTaintChecker (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D720

[PATCH] D72035: [analyzer][NFC] Use CallEvent checker callback in GenericTaintChecker

steakhal marked 5 inline comments as done. steakhal added a comment. In D72035#1889320 , @Szelethus wrote: > Wow. Its a joy to see you do C++. LGTM. Are you planning to introduce > `CallDescriptionMap` at one point? :) Yes, definitely. ==

[PATCH] D72035: [analyzer][NFC] Use CallEvent checker callback in GenericTaintChecker

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Herald added a subscriber: martong. Wow. Its a joy to see you do C++. LGTM. Are you planning to introduce `CallDescriptionMap` at one point? :) Comment at: clang/lib/S

[PATCH] D72035: [analyzer][NFC] Use CallEvent checker callback in GenericTaintChecker

steakhal updated this revision to Diff 243492. steakhal added a comment. Rebased on top of master, instead of D71524 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72035/new/ https://reviews.llvm.org/D72035 Files:

[PATCH] D72035: [analyzer][NFC] Use CallEvent checker callback in GenericTaintChecker

Szelethus added a comment. Hmm, have you branched off of D71524 ? If so, this patch should definitely land first. Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:165 /// Given a pointer argument, return the value it poi

[PATCH] D72035: [analyzer][NFC] Use CallEvent checker callback in GenericTaintChecker

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:385 +unsigned getNumArgs(const CallEvent &Call) { + return Call.getNumArgs() + static_cast(isa(Call)); } steakhal wrote: > I'm not sure why should we adjust (//work

[PATCH] D72035: [analyzer][NFC] Use CallEvent checker callback in GenericTaintChecker

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:385 +unsigned getNumArgs(const CallEvent &Call) { + return Call.getNumArgs() + static_cast(isa(Call)); } I'm not sure why should we adjust (//workaround//) the

[PATCH] D72035: [analyzer][NFC] Use CallEvent checker callback in GenericTaintChecker

steakhal created this revision. steakhal added reviewers: NoQ, Szelethus, boga95. steakhal added a project: clang. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, whisperity. steakhal added a parent revision: D