[PATCH] D72066: [clangd] Assert that the testcases in LocateSymbol.All have no diagnostics

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61301 tests passed, 0 failed and 736 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72066: [clangd] Assert that the testcases in LocateSymbol.All have no diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rG751d4dae3284: [clangd] Assert that the testcases in LocateSymbol.All have no diagnostics (authored by nridge). Changed prior to commit: https://reviews.llvm.org/D72066?vs=236608&id=236612#toc Repositor

[PATCH] D72066: [clangd] Assert that the testcases in LocateSymbol.All have no diagnostics

nridge updated this revision to Diff 236608. nridge marked an inline comment as done. nridge added a comment. Address nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72066/new/ https://reviews.llvm.org/D72066 Files: clang-tools-extra/clangd/u

[PATCH] D72066: [clangd] Assert that the testcases in LocateSymbol.All have no diagnostics

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:519 +ASSERT_TRUE(AST.getDiagnostics().empty()) +<< AST.getDiagnostics().begin()->Message

[PATCH] D72066: [clangd] Assert that the testcases in LocateSymbol.All have no diagnostics

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61163 tests passed, 0 failed and 728 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72066: [clangd] Assert that the testcases in LocateSymbol.All have no diagnostics

nridge updated this revision to Diff 235970. nridge marked 3 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72066/new/ https://reviews.llvm.org/D72066 Files: clang-tools-ext

[PATCH] D72066: [clangd] Assert that the testcases in LocateSymbol.All have no diagnostics

kadircet added a reviewer: kadircet. kadircet added a comment. thanks for taking a look at this! Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:447 struct X { - X& [[operator]]++() {} + X& [[operator]]++() { return *this; } };

[PATCH] D72066: [clangd] Assert that the testcases in LocateSymbol.All have no diagnostics

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61162 tests passed, 0 failed and 728 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72066: [clangd] Assert that the testcases in LocateSymbol.All have no diagnostics

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Also fix some bugs in the testcases which this exposed. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72066 Fil