[PATCH] D72085: [clangd] Fix hover for functions inside templated classes

2020-01-03 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet abandoned this revision. kadircet added a comment. nope i haven't, thanks for taking care ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72085/new/ https://reviews.llvm.org/D72085 ___ cfe-com

[PATCH] D72085: [clangd] Fix hover for functions inside templated classes

2020-01-02 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. I landed a patch that does exactly this a few days ago: 14e11005d1a6ac1fecb230c470e9011d6956b8e4 Did you pull the latest changes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D72085: [clangd] Fix hover for functions inside templated classes

2020-01-02 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61043 tests passed, 0 failed and 728 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72085: [clangd] Fix hover for functions inside templated classes

2020-01-02 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/235 Repository: rG LLVM Github Monorepo https://reviews.llvm.org