This revision was automatically updated to reflect the committed changes.
Closed by commit rG8e780252a728: [X86] ABI compat bugfix for MSVC vectorcall
(authored by rnk).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72110/new/
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72110/new/
https://reviews.llvm.org/D72110
merge_guards_bot added a comment.
{icon check-circle color=green} Unit tests: pass. 61177 tests passed, 0 failed
and 729 were skipped.
{icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings
rnk updated this revision to Diff 236115.
rnk added a comment.
- ZYXMM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72110/new/
https://reviews.llvm.org/D72110
Files:
clang/include/clang/CodeGen/CGFunctionInfo.h
rnk marked an inline comment as done.
rnk added inline comments.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:1648
+ // a bit different than the x64 version. First, all vector types (not HVAs)
+ // are assigned, with the first 6 ending up in the YMM0-5 or XMM0-5
registers.
+
craig.topper added inline comments.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:1648
+ // a bit different than the x64 version. First, all vector types (not HVAs)
+ // are assigned, with the first 6 ending up in the YMM0-5 or XMM0-5
registers.
+ // This differs from the
erichkeane added a comment.
I don't see anything I have a problem with, but still want @ctopper to have a
bit of time to take a look. Ping me monday on both if he doesn't respond.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72110/new/
merge_guards_bot added a comment.
{icon check-circle color=green} Unit tests: pass. 61175 tests passed, 0 failed
and 729 were skipped.
{icon check-circle color=green} clang-tidy: pass.
{icon times-circle color=red} clang-format: fail. Please format your changes
with clang-format by running
rnk created this revision.
rnk added reviewers: erichkeane, craig.topper.
Herald added a project: clang.
Before this change, X86_32ABIInfo::classifyArgument would be called
twice on vector arguments to vectorcall functions. This function has
side effects to track GPR register usage, and this
